Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views_ui.module
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
12 Nov 2012 at 00:21 UTC
Updated:
29 Jul 2014 at 21:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerAssign to myself.
Comment #2
dawehnerSo far this should work, though there is one fundamental issue behind it (which probably also causes contextual filters to fail).
The actual POST request produces a 302 which leads to a GET request, which does not have the ajax_page_state attached anymore,
which automatically leads to the problem that no new js is added.
For reference i uploaded both the network output of d7 and d8 when you click on preview.
Comment #3
dawehnerThis one has a dependency on #1841442: Contextual filters are broken in the Views UI preview, so this actual code can be already reviewed
Comment #5
dawehner#2: drupal-1837982-2.patch queued for re-testing.
Comment #6
dawehner#2: drupal-1837982-2.patch queued for re-testing.
Comment #7
tim.plunkettGoing to write a test
Comment #8
tim.plunkettComment #9
tim.plunkettWhoops, left a test method commented out
Comment #10
dawehnerThe tests are looking great, so they are looking RTBC.
Comment #11
aspilicious commentedThis means we seriously lacking tests ;). Good job in finding/fixing this and writing a test for it. Go VDC team!
Comment #12
catch#9: vdc-1837982-9.patch queued for re-testing.
Comment #14
tim.plunkettviews_ui/theme/theme.inc is now views_ui/views_ui.theme.inc
Comment #15
dawehnerBack to rtbc.
Comment #16
catchCommitted/pushed to 8.x, thanks!