Remove redundant admin labeling on AreaPluginBase

Let's get rid of "label" for both relationships and areas and just use admin titles.

Who could know that we have tests for that ;)

git diff should be aliazed to pull :)

#6: drupal-1838010-6.patch queued for re-testing.

Let's see if it still applies, if so, looks good to go. I def don't think we need both label and admin label. People don't use them a great deal anyway from my experience :)

Rerolled.

#10: drupal-1838010-10.patch queued for re-testing.

Rerole!!

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/RelationshipPluginBase.phpundefined
@@ -86,7 +75,7 @@ protected function defineOptions() {
+    $options['admin_label']['default'] = $label;

heh, I guess we didn't have this in the definition before then?

This looks like a nice tidy up. I think this is already covered by some tests? If not, we should add some basic coverage.

Sorry.

It doesn't seem to be the case yet, though there are generic tests for all handlers in the UI so it's pretty easy to extend them.

Just another rerole.

#18: drupal-1838010-18.patch queued for re-testing.

Rerolled against the refactoring of the UI.

Patch looks pretty good!

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/area/AreaPluginBase.phpundefined
@@ -74,12 +64,9 @@ public function adminSummary() {
+    unset($form['admin_label']['#fieldset']);

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/RelationshipPluginBase.phpundefined
@@ -98,13 +87,9 @@ protected function defineOptions() {
+    unset($form['admin_label']['#fieldset']);
+    $form['admin_label']['#weight'] = -1;

Should we just make this change in HandlerBase now? Then we could remove these overrides.

Thanks for the review!

Should we just make this change in HandlerBase now? Then we could remove these overrides.

I think now that it would be probably more useful to have this override just on the relationship. There it's a primary task to set an admin label, but on the area it's not that common to do it.

Like it. Nice tidy up.

#23: drupal-1838010-23.patch queued for re-testing.

Just a rerole.

This was already RTBC.

Better title, I think?

#27: drupal-1838010-27.patch queued for re-testing.

#27: drupal-1838010-27.patch queued for re-testing.

#27: drupal-1838010-27.patch queued for re-testing.

Just a rerole.

Committed 49861cc and pushed to 8.x. Thanks!