Db_select condition at the top of password_policy_cron always return TRUE.

CommentFileSizeAuthor
#5 password_policy-cron_never_short_circuits-1838342-4.patch783 byteserikwebb
#3 password_policy-cron_never_short_circuits-1838342-3.patch782 byteserikwebb
#2 password_policy-cron_never_short_circuits-1838342-2.patch375 byteserikwebb
#1 password_policy-1838342.patch470 bytespolynya

Comments

polynya’s picture

polynya commented
StatusFileSize
new password_policy-1838342.patch470 bytes

Here is a patch for 7.x-1.3.

erikwebb’s picture

erikwebb commented
Title: Db_select condition at the top of password_policy_cron always return TRUE » Cron never short circuits - bad count query
Status: Active » Needs review
StatusFileSize
new password_policy-cron_never_short_circuits-1838342-2.patch375 bytes

Thanks for pointing this out. According to the documentation, we should actually use something slightly different - https://drupal.org/node/310075#count_queries

Try this patch out.

erikwebb’s picture

erikwebb commented
StatusFileSize
new password_policy-cron_never_short_circuits-1838342-3.patch782 bytes

This looks a little cleaner to me.

Status: Needs review » Needs work

The last submitted patch, password_policy-cron_never_short_circuits-1838342-3.patch, failed testing.

erikwebb’s picture

erikwebb commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-cron_never_short_circuits-1838342-4.patch783 bytes
dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented
Status: Needs review » Reviewed & tested by the community

This also happened to fix the odd issue where password_policy module was somehow re-calling cron.php.

erikwebb’s picture

erikwebb commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/password_policy.git/commit/845749b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.