Closed (fixed)
Project:
Commerce Estonian payments
Version:
7.x-1.2
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Nov 2012 at 13:23 UTC
Updated:
25 Nov 2012 at 16:34 UTC
Notice: Use of undefined constant ERROR - assumed 'ERROR' in commerce_ep_transaction() (line 137 of xxxxxxxxx/sites/all/modules/commerce_ep/commerce_ep.module).
if (!isset($key_test) && !isset($nordea_test)) {
return drupal_set_message(t('Keys doesnt validate contact an administrator'), ERROR);
}
Shoud be:
if (!isset($key_test) && !isset($nordea_test)) {
return drupal_set_message(t('Keys doesnt validate contact an administrator'), 'error');
}
Comments
Comment #1
egontinno commentedActually there are more problems when you come back from bank with cancelled payment. This module doesn't redirect when payment failed and doesn't log that failure. Customer is directed to order completed page, order status is marked "Pending" and invoice is sended as well. I call this critical bug, because customer can purchase goods without payment.
The following code will correct this error.
Comment #2
kaido.toomingas commentedThank you! These will be on the next version. And generally you should you patch the code next time :).
Comment #3
kaido.toomingas commentedFixed