Closed (won't fix)
Project:
Drupal core
Version:
6.x-dev
Component:
database system
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
16 Oct 2007 at 14:11 UTC
Updated:
21 Nov 2007 at 16:16 UTC
Jump to comment: Most recent file
This is a split version of previous patch: http://drupal.org/node/178555. This patch only consider about the reorder and group up of mysql's related *.inc, plus a minor change to internal function name from _db_create_keys_sql() => _db_create_keys(), which synchronize with pgsql version. No change to db_query_range() and db_query_temporary() as that will consider as another issue. Should be trivial to commit.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drupal-6.x-dev-database_mysql_common-0.4.patch | 25.44 KB | hswong3i |
| #2 | drupal-6.x-dev-database_mysql_common-0.3.patch | 25.43 KB | hswong3i |
| #1 | drupal-6.x-dev-database_mysql_common-0.2.patch | 25.43 KB | hswong3i |
| drupal-6.x-dev-database_mysql_common-0.1.patch | 24.91 KB | hswong3i |
Comments
Comment #1
hswong3i commentedPatch reroll via latest CVS HEAD, plus the enclose of
@ingroup databaseand@} End of "ingroup database".within database.mysql-common.inc, to ensure the document generate correctly. It is now tested for MySQL 5.0.32 on Debian etch 4.0r1 with PHP 5.2.0-8+etch7, with a complete test for core installation and all modules installation. Should be trivial to commit, as a coding style cleanup for a simpler maintenance :)Comment #2
hswong3i commentedPatch reroll via latest CVS HEAD. It is simple enough, with no critical logic change, and ready for commit. May someone give me a hand?
Comment #3
hswong3i commentedPatch reroll via latest CVS HEAD. Already merge with #172541 for D7 preparation, so shouldn't be too hurry right now.
Comment #4
hswong3i commentedNothing will happened even without this cleanup. Don't waste time in here.