This may be an issue to the timeago module, but im not sure.

Use timeago for comment creation/changed dates enabled on admin/config/user-interface/timeago, default install, adding a comment to the event shows up like this:

<time datetime="2012-11-13T00:09:04Z" pubdate="pubdate"><span class="date-time permalink"><a href="/comment/1#comment-1" rel="bookmark">&lt;span class="timeago" title="2012-11-13T00:09:04+00:00"&gt;Tue, 11/13/2012 - 00:09&lt;/span&gt;</a></span></time>

The inner span will be shown as link, since the anchor is around it. Disabling the setting turns it into this:

<time datetime="2012-11-13T00:09:04Z" pubdate="pubdate"><span class="date-time permalink"><a href="/comment/1#comment-1" rel="bookmark">Tue, 11/13/2012 - 00:09</a></span></time>

I havent found any preprocess in the theme, so I guess this is timeagos fault?

CommentFileSizeAuthor
#13 commons-timeago-displays-html-1838928-13.patch643 bytesdevin carlson
#4 commons-timeago-displays-html-1838928.patch841 bytesprashantgoel

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Fixed

Thanks.

Ultimately this is a themeing issue, but having Timeago formatting on these links wasn't intentional, so I've disabled them:

http://drupalcode.org/project/commons_activity_streams.git/commit/51c0892

ezra-g’s picture

ezra-g commented
Component: Code » Theme
Status: Fixed » Active
ezra-g’s picture

ezra-g commented
Priority: Normal » Major
prashantgoel’s picture

prashantgoel commented
Status: Active » Needs review
StatusFileSize
new commons-timeago-displays-html-1838928.patch841 bytes

Submitting the patch for resolving this issue.

matt v.’s picture

matt v. commented
Status: Needs review » Reviewed & tested by the community

The patch in #4 worked for me.

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

This is a patch to AdaptiveTheme's at_core project. Should it be a patch against Commons Origins?

WebSinPat’s picture

WebSinPat commented

Hello, I'm having the same issue in commons 7.x.3.2
I'm just wondering what is the correct fix i should apply..
Is the commit in #1 already supposed to be in code? Or should I apply the patch in #4? Or not apply the patch based on the comment in #6?

Well, i applied the patch in #4 and it fixed the issue of the html being printed to the screen.

However, I am still not getting a timeago type of date format. It still just has regular date and time.

Submitted by admin Sat, 05/04/2013 - 11:27

Is this a related issue, or should i file a new issue?

thanks.

cellar door’s picture

cellar door commented

If you take a look at #1996706: Timeago Patch Breaks functionality you'll see the js for timeago was removed in a patch recently. Putting those lines back into the module loads the helper js file and timeago works again.

devin carlson’s picture

devin carlson commented
Version: » 7.x-3.2
Assigned: Unassigned » devin carlson
Status: Postponed (maintainer needs more info) » Needs review

This issue is caused by AdaptiveTheme wrapping comments in a link back to the comment itself.

Patch to AdaptiveTheme with workaround for Commons Origins incoming...

devin carlson’s picture

devin carlson commented
Version: 7.x-3.2 » 7.x-3.x-dev

Filed #2018081: Comment creation date links to same location as comment title against AdaptiveTheme.

stupiddingo’s picture

stupiddingo commented
Status: Needs review » Reviewed & tested by the community

Tested and marked #2018081: Comment creation date links to same location as comment title as RTBC. Same is true here I suppose?!

behoppe333’s picture

behoppe333 commented

Newbie question: When I drush make a fresh instance of dev release, I won't see this patch until its status changes from RTBC to Fixed. Correct?

I ask because my fresh instance of dev release has this bug, I'm new to this community, and I'm making sure I understand how patches flow via commits to the code that I pull with git.

Thanks for any corrections or affirmations :-)

devin carlson’s picture

devin carlson commented
StatusFileSize
new commons-timeago-displays-html-1838928-13.patch643 bytes

A patch to include the fix from #2018081: Comment creation date links to same location as comment title.

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Fixed

Committed #13 to Commons 7.x-3.x.

http://drupalcode.org/project/commons.git/commit/447147f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.