Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
field system
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 Nov 2012 at 05:46 UTC
Updated:
29 Jul 2014 at 21:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
plachComment #2
berdirA first patch. Add the item classes and converted a basic test to it.
Comment #4
berdirThis should fix the test failure.
Comment #5
berdirThis patch adds a dependency to options.module on number and text. Conceptually, that makes sense to me, because this module basically provides extended versions of the integer/float/text field types.
The other question is here if we need more tests. We're not adding new field item type classes, so IMHO adding more unit tests for those would be pointless. As said above, there are a lot of tests for allowed values, callbacks and similar things that I'm already in the process of converting to NG in #1822000: Remove Drupal\field_test\Plugin\Entity\Type\TestEntity in favor of EntityTest.
Comment #6
das-peter commentedThis looks pretty good to me, and I know I need the
'field item class'definitions for #1818556: Convert nodes to the new Entity Field API.So even if I just mainly did a visual review I'm bold enough to set this RTBC.
Comment #7
plachRaising priority since this is blocking a critical task: #1818556: Convert nodes to the new Entity Field API.
Comment #8
fagoPatch looks good the me as well. I agree that we want this dependencies to be able to re-use the existing fields.
Comment #9
webchickBeing forced to introduce a dependency on number module is a little unfortunate, but otherwise this looks good, and allows us to make progress on the node patch.
Committed and pushed to 8.x. Thanks!