Invisible Content is a Drupal module that provides a tab content types to redirect certain type to a 404 page.

This module has been designed to be used only in the content pages views.

Is a Drupal 7 module.

The project page :
http://drupal.org/sandbox/exode785/1839160

git clone http://git.drupal.org/sandbox/exode785/1839160.git invisible_content

Thank You,

Exode785

CommentFileSizeAuthor
invisible_contentv1.jpg46.73 KBexode785

Comments

parwan005’s picture

Status: Needs review » Needs work

Hi exode785,

Seems like you have committed only your .info file and not module file. Commit all the related files also with .module file, if any, along with README.txt.

Thanks

exode785’s picture

Title: Invisible content » Invisible Content
Priority: Major » Normal
Status: Needs work » Needs review

I added all the files. Thank you for your help.

grisendo’s picture

Status: Needs review » Needs work

You have some errors:

  • You are working on master branch. You should create a version branch, and work on it. You should delete master branch after that.
  • Remove "version" and "project" lines from .info file since they will be added automatically.
  • Create a README.txt
  • Description in sandbox project page is quite poor. Please, add more information, examples, similar modules (and differences with them)
  • Fix ventral review errors: http://ventral.org/pareview/httpgitdrupalorgsandboxexode7851839160git
parwan005’s picture

Hi ,

I did manual review of your code and here are the things you need to work upon other than :-

1) Do proper formatting of your code, as described here.
2) @file comment is missing from module file
3) "hook_form_node_type_form_alte" r is missing in "alter".
4) you have commented code in your js file. Please remove that.
5) Also make sure each of your file end with a new line.
6) README.txt is still missing from repo.

Thanks

grisendo’s picture

Try to use "db_select" (http://api.drupal.org/api/drupal/includes%21database%21database.inc/func... instead) of "db_query('SELECT..." for optimal compatibility with more database models.

Also, explain the differences with Nodeaccess module: http://drupal.org/project/nodeaccess. It looks like it does the same as your module, but it is more customizable, since it can be defined (i.e.) visibility by role, and it has more granularity because you can define visibility also at node level.

klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

Issue summary: View changes

Update description.