Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Nov 2012 at 14:00 UTC
Updated:
25 Jan 2013 at 12:40 UTC
Invisible Content is a Drupal module that provides a tab content types to redirect certain type to a 404 page.
This module has been designed to be used only in the content pages views.
Is a Drupal 7 module.
The project page :
http://drupal.org/sandbox/exode785/1839160
git clone http://git.drupal.org/sandbox/exode785/1839160.git invisible_content
Thank You,
Exode785
| Comment | File | Size | Author |
|---|---|---|---|
| invisible_contentv1.jpg | 46.73 KB | exode785 |
Comments
Comment #1
parwan005 commentedHi exode785,
Seems like you have committed only your .info file and not module file. Commit all the related files also with .module file, if any, along with README.txt.
Thanks
Comment #2
exode785 commentedI added all the files. Thank you for your help.
Comment #3
grisendo commentedYou have some errors:
Comment #4
parwan005 commentedHi ,
I did manual review of your code and here are the things you need to work upon other than :-
1) Do proper formatting of your code, as described here.
2) @file comment is missing from module file
3) "hook_form_node_type_form_alte" r is missing in "alter".
4) you have commented code in your js file. Please remove that.
5) Also make sure each of your file end with a new line.
6) README.txt is still missing from repo.
Thanks
Comment #5
grisendo commentedTry to use "db_select" (http://api.drupal.org/api/drupal/includes%21database%21database.inc/func... instead) of "db_query('SELECT..." for optimal compatibility with more database models.
Also, explain the differences with Nodeaccess module: http://drupal.org/project/nodeaccess. It looks like it does the same as your module, but it is more customizable, since it can be defined (i.e.) visibility by role, and it has more granularity because you can define visibility also at node level.
Comment #6
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #6.0
klausiUpdate description.