BBox argument handler doesn't work with GROUP BY [#1839462]

Posted by dasjo on November 13, 2012 at 3:35pm

2 followers

Issue Summary

currently, views_geojson_bbox_argument uses query->add_where for adding the bounding box filters to the views query.

this doesn't work with aggregation being enabled, thus we should investigate using a more robust and generic approach.

Posted by dasjo on November 13, 2012 at 4:20pm

Status:

active

» needs review

the attached patch is a rather a workaround than generalizing the problem, but it should help :)

Attachment	Size
1839462_views_geojson_bbox_group_by_having.patch	2.98 KB

Posted by dasjo on November 13, 2012 at 4:22pm

without the search api patch

Attachment	Size
1839462_views_geojson_bbox_group_by_having.patch	2.03 KB

Posted by clemens.tolboom on January 21, 2013 at 10:57am

Status:

needs review

» needs work

Why is the patch a workaround? What should it contain?

Reading http://api.drupal.org/api/views/handlers!views_handler_sort_group_by_numeric.inc/7 we should do more indeed.

But according #1806048: BBOX filter not working we should add at least add

<?php
  function query($group_by = FALSE) {
?>

to this patch.

Posted by clemens.tolboom on January 21, 2013 at 11:17am

Status:

needs work

» needs review

Added the method argument as mentioned in #3

Attachment	Size
views_geojson-groupby-bbox-workaround-4.patch	2.35 KB