1. Let's rename this file (list_changes.feature) to changerecords_list.feature, to be in line with the files for other sections.
2. The files also needs tag @changerecords
3. Scenario: Navigate through pagination links: Last page

Then I should see at least "10" records

This should be changed to 1 since it's completely possible to have less than 10 records on the last page.
4. Scenario: Add new change record as anonymous user should be moved to list_changes_authenticated.feature file (we'll remove authenticated from file name so that's not a problem)

Even after moving 1 scenario, the file still will have 14, which is a lot. Though they all are quite similar and I don't see now how to break them into more files.

Comments

sachin2dhoni’s picture

Assigned: Unassigned » sachin2dhoni
Status: Active » Needs review
Issue tags: +sprint 16
tvn’s picture

Title: Update list_changes.feature file » Update changerecords_list.feature file

Looks good to me, thanks.

tvn’s picture

Just noticed, old list_changes.feature file is still there, should be removed:
http://drupalcode.org/project/doobie.git/blob/HEAD:/features/drupalorg/l...

kssundar’s picture

Status: Needs review » Needs work

This needs work

kssundar’s picture

Status: Needs work » Needs review
Issue tags: +sprint 17
sachin2dhoni’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue tags: +sprint 18
eliza411’s picture

Status: Needs review » Needs work

This test requires manual intervention with the .htaccess to pass. We can get the testing server whitelisted, but those scenarios should get marked with @htaccess so that someone running tests manually will know it's an expected failure unless they, too, have been whitelisted (which is unlikely)

Otherwise, looks as ready as it can be until D7 Drupal.org is ready for feedback.

kssundar’s picture

Assigned: sachin2dhoni » Unassigned
Status: Needs work » Needs review
Issue tags: +sprint 19

Not sure why it asks for username and pass, but i have removed @javascript tag as there is only one scenario that requires it. Now, the feature does not ask for .htaccess to pass.

http://drupalcode.org/project/doobie.git/commit/64eca60

eliza411’s picture

Status: Needs review » Reviewed & tested by the community

That will do it, thank you.

eliza411’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Postponed until d7 output is complete. See #1839512: Update changerecords.feature

eliza411’s picture

Issue summary: View changes

.