1. Let's rename this file (list_changes.feature) to changerecords_list.feature, to be in line with the files for other sections.
2. The files also needs tag @changerecords
3. Scenario: Navigate through pagination links: Last page
Then I should see at least "10" records
This should be changed to 1 since it's completely possible to have less than 10 records on the last page.
4. Scenario: Add new change record as anonymous user should be moved to list_changes_authenticated.feature file (we'll remove authenticated from file name so that's not a problem)
Even after moving 1 scenario, the file still will have 14, which is a lot. Though they all are quite similar and I don't see now how to break them into more files.
Comments
Comment #1
sachin2dhoni commentedUpdated to 6x branch with the changes.
Please check the commitlog:
http://drupalcode.org/project/doobie.git/commit/58eae6d
http://drupalcode.org/project/doobie.git/commit/f547d17
Comment #2
tvn commentedLooks good to me, thanks.
Comment #3
tvn commentedJust noticed, old list_changes.feature file is still there, should be removed:
http://drupalcode.org/project/doobie.git/blob/HEAD:/features/drupalorg/l...
Comment #4
kssundar commentedThis needs work
Comment #5
kssundar commentedRemoved the file here - http://drupalcode.org/project/doobie.git/commit/c77c936
Comment #6
sachin2dhoni commentedPorted to d7
http://drupalcode.org/project/doobie.git/commit/c23dfe8
Comment #7
eliza411 commentedThis test requires manual intervention with the .htaccess to pass. We can get the testing server whitelisted, but those scenarios should get marked with @htaccess so that someone running tests manually will know it's an expected failure unless they, too, have been whitelisted (which is unlikely)
Otherwise, looks as ready as it can be until D7 Drupal.org is ready for feedback.
Comment #8
kssundar commentedNot sure why it asks for username and pass, but i have removed @javascript tag as there is only one scenario that requires it. Now, the feature does not ask for .htaccess to pass.
http://drupalcode.org/project/doobie.git/commit/64eca60
Comment #9
eliza411 commentedThat will do it, thank you.
Comment #10
eliza411 commentedPostponed until d7 output is complete. See #1839512: Update changerecords.feature
Comment #10.0
eliza411 commented.