Follow-up to #1328552: Add support for Coder code reviews and Syntastic plugin and #1839780: Update installation script to download plugins: The installation script can also download the Coder module (if it is not already installed). Can we also automate the installation of PHP_CodeSniffer? The DrupalCS project has been combined with Coder, and we should make sure we stay up to date.

Installation change

The current instructions on http://drupal.org/node/1419988 include

sudo ln -sv /path/to/coder/coder_sniffer/Drupal $(pear config-get php_dir)/PHP/CodeSniffer/Standards/Drupal

After the patch in #2, the Vimrc configuration looks for Standards/Drupal instead of Standards/DrupalCodingStandard.

CommentFileSizeAuthor
#2 update-coder-1839806-2.patch657 bytesbenjifisher

Comments

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

Starting with the 7.x-2.x branch of Coder, it includes the DrupalCS module. For now, that means either using git or$ drush dl coder-7.x-2.x --destination=$HOME/.drush
to get the 7.x-2.x-dev release. This merits several comments:

  1. Without the --destination option, Coder will be downloaded to the appropriate modules directory or to the current directory. I tested with and without the @none site alias on my Mac's guest account.
  2. When I tried ~/.drush instead of $HOME/.drush I got a new directory ~ under the current one.
  3. I do not want to add anything to our installation script that specifies which version of Coder to download. It is possible that someone will run our script when it is very stale and end up downgrading her version of Coder. For now, I will simply add installation of Coder to our own installation instructions. It may be best to keep it that way.

In the issue summary, I asked about installing PHP_CodeSniffer. The right place to work on that is #1829128: make it easier to install and check for PHP CodeSniffer.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
StatusFileSize
new update-coder-1839806-2.patch657 bytes

The attached patch is one step in the right direction, reflecting updated installation instructions on http://drupal.org/node/1419988.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

As of January 4, the recommended version of Coder is 7.x-2.0-beta1. I think it is time to resolve this issue. Do we need anything more than the patch in #2?

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Active » Fixed

Fixed and committed: 387650e.

I also updated the issue summary.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Add a note describing the configuration change and a link to the Coder installation instructions.