Closed (fixed)
Project:
Bot
Version:
6.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Oct 2007 at 21:10 UTC
Updated:
7 Jul 2008 at 17:22 UTC
Jump to comment: Most recent file
hook_help implementations sometimes return an empty string when there is no help - e.g. pathauto_help(), actions_help(), but these get added to the array when hook_help is invoked via module_invoke_all() as in bot.module, resulting in "empty" features being listed, e.g. (22:09:11) Druplicon_tmp: Detailed information is available by asking for "help <feature>" where <feature> is one of: , Botagotchi, Drupal URLs, Factoids, Function Lookups, Seen. (note the comma at the start of the feature list)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | bot-help_0.patch | 2.22 KB | john morahan |
| #1 | bot-help.patch | 2.22 KB | john morahan |
Comments
Comment #1
john morahan commentedComment #2
john morahan commentedtypo
Comment #3
morbus iffThis is actually a bug in those modules, not in bot.module. Both actions.module and pathauto.module always preinit $output to '' (as opposed to NULL) and always return $output, regardless if the module help properly fires. This is not something that any of the core modules do, and is bad design. Akismet.module does it also. Whilst I agree that your fix would get rid of these errors, I don't find them MY errors to get rid of - they should be fixed in the source module (and I heartily will support you creating issues in their queues that refer to this explanation).
Comment #4
morbus iffThis also occurs with the triggers.module of Drupal 6 (which is actions.module in disguise).
Comment #5
morbus iffSee also http://drupal.org/node/184722.
Comment #6
john morahan commentedI agree it is bad design. I guess the reason it doesn't come up, is that help.module itself doesn't breaks when this happens, due to the unusual ways it invokes this hook.
Okay, off I go to create more bug reports.
Comment #7
john morahan commentedThis is now fixed in pathauto and actions, still waiting for akismet but I guess nothing more needs to be done here.
Comment #8
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #9
morbus iffReopening. I should probably do this cos people aren't learning.
Comment #10
morbus iffFixed in DRUPAL-6--1. Thanks!
Comment #11
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.