Closed (fixed)
Project:
Drupal Commons
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
14 Nov 2012 at 15:07 UTC
Updated:
29 Nov 2012 at 23:10 UTC
Jump to comment: Most recent file
Not when the form is generated. Bad ezra-g ;).
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | commons_groups_check_if_Published-1840592-1.patch | 1.14 KB | pierrepaul |
Comments
Comment #1
pierrepaul commentedYou already did a check if the node was published, but you did it in the form_state (I guess you were tired :P). Here I removed the $node->status in the form_alter. I'm not 100% sure it's the best idea to check for the state of the status in the form_state.
I know _validate checked if it was a good value, but let's say someone is using to hook_insert() to play around the status variable, we would still output the message.
I could use the hook_insert myself, but I feel like it doesn't belong there and it's overkill. What do you think?
Comment #2
ezra-g commentedCommitted - Thanks!
http://drupalcode.org/project/commons_groups.git/commit/ca9486d