HaLe Mail is an email marketing platform using state of the art technology which permits you to send emails to your different email databases.
This 100% online tool combines a high level of performance and penetration with an enormous ease of use. Thanks to its advanced statistics, you will
know everything about your emailing campaign, which allows you to further develop and finetune your emailing strategies no matter where you are located in the world!

The HaLe Mail 3.0 (Un)Subscribe module will allow you to create a block for each one of your "public" mailing lists. Each block is built up out of a "subscribe" tab containing all fields which are in that specific mailing list, and an unsubscribe tab which will allow for people to unsubscribe to that mailing list based on their email address.

Sandbox page:
http://drupal.org/sandbox/Lajfi/1840540

GIT:
git clone --recursive --branch master Lajfi@git.drupal.org:sandbox/Lajfi/1840540.git

Drupal version => 7

Comments

parwan005’s picture

parwan005 commented
Status: Needs review » Needs work

Hi,

Here is my manual review of your code: -

1) Make sure all of your module functions prefix your module name in them.
2) // $Id: $ is no longer required. So you can remove this.
3) You have empty .install file in your module. Make sure you remove all related variables of your module after uninstall.
4) Make sure you give default value to your variable when using variable_get method.
5) Make sure each of your file end with a new line. README.txt not doing this.
6) You have 2 .info files in your module. Please fix this.

Also make sure to fix your ventral issues here : http://ventral.org/pareview/httpgitdrupalorgsandboxlajfi1840540git

vineet.osscube’s picture

vineet.osscube commented

Hi,
manual review:
Use opening, closing parenthesis into if control statement in line no 157 hm_subscriptions.module.

Lajfi’s picture

Lajfi commented
Status: Needs work » Needs review

I have checked your remarks and made the necessary changes

http://ventral.org/pareview/httpgitdrupalorgsandboxlajfi1840540git-v10

can you please review?

thx

sirup’s picture

sirup commented
Status: Needs review » Needs work

Plase change your git clone line, so that it works for everybody. The one you wrote assumes we all are using your account :-)

git clone --recursive --branch master http://git.drupal.org/sandbox/Lajfi/1840540.git hale_mail_3_0__un_subscribe

Some small points:

  • Please remove the .project file from version control
  • Rename your branch to 7.x-1.x
  • Remove version line from info file
  • Please delete the master branch
  • consider using another package name which is more generic

Other points:

  • please dont use the files[] directive for your module and install file (the files[] statement is for OOP classes/interfaces)
  • please remove your variables via variable_del within the uninstall_hook in your install file
  • the README instructs to move the "webform" folder .. copy paste error?
    • sirup’s picture

    sirup commented

    One more thing: I would recommend to put your api module inside the subscribe/unsubscribe module.

    You can have more than one module within a project. Therefore, somebody could still enable only the api module if needed. Anyway, please ensure that both modules adhere to the coding standards when published (the api module lacks code comments and does not use the coding standards at the moment everywhere).

    klausi’s picture

    klausi
    he/him||they/them
    Primary language German
    Location 🇦🇹 Vienna
    commented
    Status: Needs work » Closed (won't fix)

    Closing due to lack of activity. Feel free to reopen if you are still working on this application.

    If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)