Closed (fixed)
Project:
BOTCHA Spam Prevention
Version:
6.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 Nov 2012 at 16:28 UTC
Updated:
4 Dec 2012 at 10:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
PatchRanger commentedYes, it is now "protected" by "Forbidden forms" recipe book, which is created for "protection against protection".
Let me explain why user_login form has become forbidden. If some enabled recipe appears to be broken, then fixing it becomes a critical issue, since you have no chance to log in again once you logged out. We should have no protection at all on such forms (like user_login, user_login_block and update_script_selection_form that are all in forbidden_forms currently) rather than being in a situation of a permanent force-major.
Please give a use case of login form protection: why do you need it? User_register form is protected as usually - no exceptions. But why to protect login form? If a spam bot does not have an account, it couldn't log in in any case, right? And if it has - you should ban the user.
Let me know if I misunderstand something. Feel free to reopen the issue in that case.
Comment #2
salvisMy use case: I have spambots that created accounts, and some of them keep trying to log in. The accounts are blocked, but having an additional line of defense would be comforting.
I understand your frustration about getting critical issues in your queue. I'd implement something like a botcha_disable variable that can be set to TRUE in settings.php in order to get back in. Force the user to put botcha_disable=FALSE into their settings.php before they can enable BOTCHA on the critical forms.
Comment #3
PatchRanger commentedOr by variable_set. That is interesting in any case. Let's turn it into feature request.
Comment #4
iva2k commentedThe importance of problem of getting back in (i.e. disabling Botcha on login forms) will fade when all recipes are fully debugged.
Having it disabled at all times is not a good decision as there are spammers that use humans to create accounts but then pass the accounts to the scripts. Therefore we need to have options available to protect any form on spammers path - register, login, post content.
Said that, it appear to me a simple setting in the settings.php should be sufficient> It can either be a setting that lists all forms to disable Botcha (override Botcha settings), or boolean "enable the disable feature of Botcha" or whatever name can suit better (I think "unprotect login forms").
Comment #5
PatchRanger commentedComment #7
PatchRanger commentedSome words about what has been done.
And also:
Comment #8
PatchRanger commentedComment #9
PatchRanger commentedFixed in D7: http://drupalcode.org/project/botcha.git/commit/d203d60.
Comment #10
PatchRanger commentedComment #11
PatchRanger commentedComment #13
PatchRanger commentedComment #15
PatchRanger commentedAdditional bugfix for D7.
Comment #17
PatchRanger commentedComment #18
PatchRanger commentedFinally for D6.
Comment #20
PatchRanger commentedComment #21
PatchRanger commentedFixed for D6 as well: http://drupalcode.org/project/botcha.git/commit/65830a9.