I ran Login Security through the Coder module and corrected some things such as commas without following spaces and tabs instead of double spaces. It's possible that your editor or IDE hasn't been configured to the Drupal coding standards, and if you use Komodo or Eclipse, each can be configured to automatically follow the coding standards at http://drupal.org/coding-standards

The attached patch also corrects English spelling and grammar in a few places, and while I was at it I made the wording a little more consistent throughout the module. My intention is to help make this module easier to understand.

I didn't change the double quotes to singles or do anything else that would improve performance.

CommentFileSizeAuthor
#1 login_security_install.patch1.21 KBChristefano-oldaccount
login_security_strings.patch16.91 KBChristefano-oldaccount

Comments

Christefano-oldaccount’s picture

Christefano-oldaccount commented
StatusFileSize
new login_security_install.patch1.21 KB

Here is the login_security.install file after running it through the Coder module.

ilo’s picture

ilo commented

I've applied the patches and also update the cvs repository.

Thanks a lot for your job! The options you suggested give more power to the module, the strings now look better, and the code cleanup helps everyone following the coding standards.

I think the module is close to the 1.0 official release, but I don't want to do the 1.0 snapshot before remembering we still have a pending task: to notice about the number of login attempts remaining.. The only way we could consider with the current source is to perform the count remaining for an IP address.. is this right for you? also, what is the best way to notice the user about that.. a normal message (drupal_set_message) in the drupal page? show an error string (with form_set_error)? do we show an special page or an special popup?

Christefano-oldaccount’s picture

Christefano-oldaccount commented
Status: Active » Closed (fixed)

Thanks! I've opened a new issue with notes about messages containing remaining login attempts: http://drupal.org/node/184487

This module is great. Thank you for this very good work.