I think there is no need to have separate file for language field. I suggest we rename it to user_profile_personal.feature and add tests for other fields on the "Personal information" tab.

Tests should:
1. fill in all fields on the tab, save and see that texts/links show up on the profile page
2. fields for urls (e.g. Twitter) should not accept invalid urls
3. after filling fields and saving - follow links for Gender and Country and see that pages "People who are" and "People who live in" are present.

Proposed feature update:
Feature: Personal information in user profile
In order to share information about myself
As an authenticated user
I should be able to edit my profile and fill in personal information

Comments

kssundar’s picture

kssundar commented
Assigned: Unassigned » kssundar
Issue tags: +sprint 17

Assigning and tagging

kssundar’s picture

kssundar commented
Status: Active » Needs review

Feature updated and committed here - http://drupalcode.org/project/doobie.git/commit/70b41df and http://drupalcode.org/project/doobie.git/commit/292a976

kssundar’s picture

kssundar commented
Title: Update user_profile_language.feature » Update user_profile_personal.feature

Updated title to match the new feature file

tvn’s picture

tvn commented

I've added couple of texts and 1 link to tests: http://drupalcode.org/project/doobie.git/commit/2392ca8
File looks good to me now.

Not sure why, but 1 scenario is failing for me:
"The text "The value provided for Google profile is not a valid URL" was not found anywhere in the text of the current page."

kssundar’s picture

kssundar commented
Status: Needs review » Needs work

Needs work actually

kssundar’s picture

kssundar commented
Status: Needs work » Needs review

The field label for Google profile field was wrongly entered. Corrected and committed here - http://drupalcode.org/project/doobie.git/commit/c68b66d

pradeeprkara’s picture

pradeeprkara commented
Issue tags: +sprint 18

Ported to 7.x branch.

http://drupalcode.org/project/doobie.git/commit/f8217a2

eliza411’s picture

eliza411 commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Needs work

I can't get this test to run to completion. It hangs trying to follow the link in the scenario on line 56 and I immediately see why. Would prefer to have it fail rather than hanging indefinitely.

kssundar’s picture

kssundar commented

Ran this with @javascript:

9 scenarios (9 passed)
79 steps (79 passed)
7m49.945s

Ran this without @javascript:

9 scenarios (9 passed)
79 steps (79 passed)
8m43.436s
eliza411’s picture

eliza411 commented

This still won't pass for me with @javascript and I hadn't tried running it without. It reliably passes without selenium. Is there something specifically being tested with the javascript tag, or can we safely remove it and call it rtbc.?

kssundar’s picture

kssundar commented

We have observed that /profile/* page takes long time to load and some time takes ages. There is no need of @javascript tag here. We can remove it and mark it rtbc.

eliza411’s picture

eliza411 commented
Status: Needs work » Fixed

Perfect. Marking fixed, actually, since all the tests are passing.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

.