I know, that you told me that resp_img and thus picture are following the specifications at http://responsiveimages.org/ and this was discussed here: #1835038: Update Picturefill to the latest release

But I was having another issue: #1828150: Not working in IE8-

So I created another patch for this.

I also have a repo for this: https://bitbucket.org/luksak/picture

Comments

luksak’s picture

StatusFileSize
new1.21 KB
luksak’s picture

StatusFileSize
new11.81 KB

Ohoh... I posted the wrong patch.

luksak’s picture

Status: Active » Needs review
luksak’s picture

StatusFileSize
new14.26 KB

And supporting multipliers with media queries the standards way and the webkit vendor prefix...

attiks’s picture

+++ b/picture.moduleundefined
@@ -574,4 +574,24 @@ function picture_get_image_dimensions($variables) {
+    $media_query = $breakpoint . ' and (-webkit-min-device-pixel-ratio: ' . $multiplier_formatted . '), ';

+ min-device-pixel-ratio
+ -o-min-device-pixel-ratio

attiks’s picture

Assigned: Unassigned » jelle_s

FYI: switched to using the span tag, because div aren't allowed inside <p />

attiks’s picture

Assigned: jelle_s » Unassigned
Status: Needs review » Fixed

Fixed in latest dev, most of #4 is incorporated, but with some changes.

aquariumtap’s picture

I'm trying to catch up on the history of this issue :) What was this ticket trying to solve? The JavaScript error mentioned in #1828150: Not working in IE8-?

Are the demos linked from the project page up to date with the latest code? IE is not supported on the D7 version, and only IE9 is supported on the D8 version.

attiks’s picture

"IE is not supported on the D7 version" what do you mean: you don't get any output, or it isn't responsive?

aquariumtap’s picture

I meant it isn't responsive, but from your response at #1828150: Not working in IE8-, it sounds like the best we can do for IE8 is specify one image style as a fallback? I can work with that, I'll just set the width: 100% / height: auto for IE, and use respond.js to resize the image container. Currently my site is showing no images in ie8 using resp_img.

I just want to confirm there's no responsive ie8 solution before migrating all of my work to the picture module backport. Thanks :)

attiks’s picture

#10 it isn't responsive, but it should be for IE9, for IE8- it will always use the fallback.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 7ab8835 on 7.x-1.x, picturefill2 authored by Lukas von Blarer, committed by attiks:
    Issue #1841062 by Lukas von Blarer: Check if the span is a picture.
    
  • Commit 65d6a27 on 7.x-1.x, picturefill2 authored by Lukas von Blarer, committed by Jelle_S:
    Issue #1841062 by Lukas von Blarer: Updating picturefill to latest...
  • Commit 5f70d9d on 7.x-1.x, picturefill2 authored by Lukas von Blarer, committed by Jelle_S:
    Issue #1841062 by Lukas von Blarer: Updating picturefill to latest...
  • Commit bef71f6 on 7.x-1.x, picturefill2 authored by Lukas von Blarer, committed by Jelle_S:
    Issue #1841062 by Lukas von Blarer: Updating picturefill to latest...

  • Commit 7ab8835 on 7.x-1.x, picturefill2, 7.x-2.x authored by Lukas von Blarer, committed by attiks:
    Issue #1841062 by Lukas von Blarer: Check if the span is a picture.
    
  • Commit 65d6a27 on 7.x-1.x, picturefill2, 7.x-2.x authored by Lukas von Blarer, committed by Jelle_S:
    Issue #1841062 by Lukas von Blarer: Updating picturefill to latest...
  • Commit 5f70d9d on 7.x-1.x, picturefill2, 7.x-2.x authored by Lukas von Blarer, committed by Jelle_S:
    Issue #1841062 by Lukas von Blarer: Updating picturefill to latest...
  • Commit bef71f6 on 7.x-1.x, picturefill2, 7.x-2.x authored by Lukas von Blarer, committed by Jelle_S:
    Issue #1841062 by Lukas von Blarer: Updating picturefill to latest...