tableheader.js interferes with #anchors in table rows

I am so sorry, I thought a lot about this (even lost some sleep) and while I find tableheader.js a real interesting idea currently it's more a proof of concept than a solid Drupal JS addition. Steven, I do not want this to be "another kick in the gut" I really appreciate your work but you are not around, this file is very broken, noone seems to be able or willing to fix so what can I do?

• It breaks the select all checkbox.
• It does not work in IE6.
• It slows down Opera.
• It breaks page anchors.

The select all bug has a working patch at http://drupal.org/node/154593.

It might be possible to check if there is an hash e.g if(location.hash) and then scroll down the height of the tableheader.

That's good news. Opera slowdown does not occur to all platforms I hear (and I tested too) and IE6 is being phased out anyways.

I'd much rather find a solution than take out the table header. This particular problem could be extra tricky though. I'll see what options we've got, though fajerstarer's idea: "It might be possible to check if there is an hash e.g if(location.hash) and then scroll down the height of the tableheader.", sounds like the approach I'd try to take also.

The select all issue is now fixed in core.

Just noting that this still applies with the latest CVS. Going to /admin/user/permissions#module-node
shows the "access content" permission, rather than the "node module" section header. With all of the recent changes to tableheader.js it seemed like a good time to check.

Accounting for anchors is really tricky but the urls mentioned here are really minor I think. Hopefully, the originating link is descriptive enough so it won't be confusing since it does fall into the right group. It only obscures the group heading, not any of the choices.

Postponed dependent issue : #184010: Add #anchors to modules administration page

This patch will scroll the page up the amount of the height of the table header when an anchor is selected. I have tested this to work except when an anchor is chosen that is the same as the previous chosen anchor.

So if you go to admin/user/permissions#module-filter it will scroll correctly. If you then go to the url bar and click enter it will not scroll correctly. I think this will be a very rare occasion and this patch fixes 99% of the situations.

Fixed comment spacing

Some screenshot love

EDIT: some better screenshots

So, this keeps the module (tablesection?) header visible where currently the scrolling tableheader covers it. Can't comment on code quality but this is an obvious usability improvement. Nice little fix. RTBC from the ux-team. (but leaving needs review for one more js-check :)

Nice work redndahead. Is there a reason why the effect needs to be animated? We could make it immediate (since its going to happen really suddenly anyway) with:

$('body, html').scrollTop(scrollLocation);

Because I was at home and didn't have my jquery book and I thought I read that scrollTop was an extension. So the answer to your question is no, but hopefully the answer to this attached patch is RTBC.

JS looks good. Tested in:
- Firefox 2/3 (Mac/Windows)
- Opera 9 (Mac)
- IE 7 (Windows, IE6 is not supported by tableheaders.js)
- Safari 3 (Mac)

Nice. This has bugged me for a long time.

Code looks good, verified that it fixes the problem, and has a thumbs-up from a JS guru and a UX guru. Good enough for me. :) Committed to HEAD. Thanks!

Moving back to 6.x for consideration.

tableheader.js seems to nicely align to coding standards with the string concatenation in Drupal 6, so I needed to make 'td' + location.hash into 'td'+ location.hash, but otherewise committed the patch as-is. Thanks!

Noticed that although the PHP string concatenations were fixed to the new standards of always whitespace around them, this JS file and possibly other JS files have the concatenation in the D6 style still. Sounds like work to do there :) (in another issue)

With this patch applied to tableheader (drupal 6.6) I get one error in pages linked with #fragments:

$("td" + location.hash).offset() is undefined
var scrollLocation = $('td'+ l...tion.hash).offset().top - $(e).height();

easily fixed with

      if (location.hash != '') {
+        if($('td'+ location.hash).length > 0) {
          var scrollLocation = $('td'+ location.hash).offset().top - $(e).height();
          $('body, html').scrollTop(scrollLocation);
+        }
      }

gunzip can you open a new issue and post a new patch?

Thanks

gustav has posted the patch requested by redndahead at #367088: tableheader.js error with anchors and it has one positive review so far.