Download & Extend

Use 2.x branch of media youtube?

Project:Panopoly
Version:7.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:demo_framework

Issue Summary

Loading a patch for the make file so i can use the 2.x branch of media youtube.

Comments

#1

patch attached

AttachmentSize
panopoly_widgets-1841956-1.patch 881 bytes

#2

Title:Use 2.x branch of media youtube» Use 2.x branch of media youtube?
Project:Panopoly Widgets» Panopoly
Version:7.x-1.x-dev» 7.x-1.x-dev
Status:closed (works as designed)» active

Should Panopoly be using the 2.x branch as well?

#3

seems to work for me. haven't tested 2.x of vimeo yet.

i needed 2.x for the ability to use the iframe api stuff.

#4

This patch updates everything media-related to 2.x dev for widgets. Needs testing.

AttachmentSize
panopoly_widgets-media-2x-dev-1841956-3.patch 1.17 KB

#5

Status:active» needs review

Seems to be working right now. Should probably add revisions in case anything breaks. :)

AttachmentSize
panopoly_widgets-media-2x-dev-1841956-5.patch 1.57 KB

#6

@brantwynn does it fix #1842782: inserting videos using wysiwyg results in preview image being used as well? I'll check later.

#7

@barraponto From my tests, it would appear that #1842782: inserting videos using wysiwyg results in preview image being used is not fixed by this.

#8

Status:needs review» fixed

Alright! I reviewed all this, pushed up the Media: Youtube and Media: Vimeo to 2.x-dev, and updated the responsive CSS for things. This still needs more testing + an upgrade path, but marking as fixed since we are rolling 2.x style.

#9

@populist - Any reason we did not also include the update to media and file_entity from #5? Is that tracked in another issue?

The Media and File Entity updates are be taken care of in #1964086: Update Modules for RC4 Release - April I guess...

#10

Upgrading from RC3 to RC4 would break stuff? It's a showstopper if we roll out a RC release that is not backwards-compatible :(

#11

@barraponto - don't worry. RC4 should be an easy update from RC3. just want to make sure (through testing) this is going to work since we are doing a major version update for Media: Youtube and Media: Vimeo. My initial testing suggests it works pretty well, but just want to make sure.

#12

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here