Loading a patch for the make file so i can use the 2.x branch of media youtube.

CommentFileSizeAuthor
#5 panopoly_widgets-media-2x-dev-1841956-5.patch1.57 KBsaltednut
#4 panopoly_widgets-media-2x-dev-1841956-3.patch1.17 KBsaltednut
#1 panopoly_widgets-1841956-1.patch881 bytesjoelcollinsdc

Comments

joelcollinsdc’s picture

joelcollinsdc commented
StatusFileSize
new panopoly_widgets-1841956-1.patch881 bytes

patch attached

populist’s picture

populist commented
Title: Use 2.x branch of media youtube » Use 2.x branch of media youtube?
Project: Panopoly Widgets » Panopoly
Status: Closed (works as designed) » Active

Should Panopoly be using the 2.x branch as well?

joelcollinsdc’s picture

joelcollinsdc commented

seems to work for me. haven't tested 2.x of vimeo yet.

i needed 2.x for the ability to use the iframe api stuff.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Issue tags: +demo_framework
StatusFileSize
new panopoly_widgets-media-2x-dev-1841956-3.patch1.17 KB

This patch updates everything media-related to 2.x dev for widgets. Needs testing.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Active » Needs review
StatusFileSize
new panopoly_widgets-media-2x-dev-1841956-5.patch1.57 KB

Seems to be working right now. Should probably add revisions in case anything breaks. :)

barraponto’s picture

barraponto
he / him
commented

@brantwynn does it fix #1842782: inserting videos using wysiwyg results in preview image being used as well? I'll check later.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

@barraponto From my tests, it would appear that #1842782: inserting videos using wysiwyg results in preview image being used is not fixed by this.

populist’s picture

populist commented
Status: Needs review » Fixed

Alright! I reviewed all this, pushed up the Media: Youtube and Media: Vimeo to 2.x-dev, and updated the responsive CSS for things. This still needs more testing + an upgrade path, but marking as fixed since we are rolling 2.x style.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

@populist - Any reason we did not also include the update to media and file_entity from #5? Is that tracked in another issue?

The Media and File Entity updates are be taken care of in #1964086: Update Modules for RC4 Release - April I guess...

barraponto’s picture

barraponto
he / him
commented

Upgrading from RC3 to RC4 would break stuff? It's a showstopper if we roll out a RC release that is not backwards-compatible :(

populist’s picture

populist commented

@barraponto - don't worry. RC4 should be an easy update from RC3. just want to make sure (through testing) this is going to work since we are doing a major version update for Media: Youtube and Media: Vimeo. My initial testing suggests it works pretty well, but just want to make sure.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rerooting’s picture

rerooting commented

Upon upgrading to media_youtube 2.x, the only problem was that the video widget was not resizing the youtube iframe properly (which was done before with javascript, though that javascript is gone in the 1.x branch of widgets now it appears). Setting the width in video file display to 100% seems to have fixed it, however.