Replace locale_project table and improve caching

Note that I would recommend to not use state() but directly call into the keyvaluestore and use your own collection. drupal_container()->get('keyvalue')->get('locale') or something like that. Allows you to do stuff like getAll() if necessary.

And, you can also use the keyvalue.expirable service as well, which allows you to put stuff in there that automatically expires, if needed.

I added a new service called locale.project which stores the projects in a keyvalue collection and removed the table from the schema definition.

TODO:
- write an interface for the LocaleProjectStorage class (needed because it is a service)
- clean up the code
- perhaps we shall rewrite those code parts where the project is used as an stdClass object.
- document what are we storing in the value (needed because schema['locale_project'] was removed

Creating interface and fixing some issues.

1. +++ b/core/modules/locale/lib/Drupal/locale/LocaleProjectStorage.php
   @@ -0,0 +1,158 @@
   +    return !empty($this->cache) ? count($this->cache) : count($this->keyValueStore->getAll());
   

   we aren't sure here that all the projects are loaded in the cache, we shall return just: count($this->getAll());

2. +++ b/core/modules/locale/lib/Drupal/locale/LocaleProjectStorage.php
   @@ -0,0 +1,158 @@
   +    return !empty($this->cache) ? $this->cache : $this->keyValueStore->getAll();
   

   here we need something like:

   static $all = FALSE;
   if (!all} {
     $this->cache = $this->getAll();
     $all = TRUE;
   }
   return $this->cache;
   

Fix for calling getAll() and other small fixes.

Re-roll.

Fixed typo in the filename and another small error that caused noticed in the one test that I tried to run.

rerolled the patch and fixed the last failing test

interdiff added

@Berdir, @Sutharsan what do you think?

@Sutharsan: thanks! We need some review here to get an RTBC :)

Here is #19

looks good. overall, SQL-- and Service(keyValue)++.

1. +++ b/core/modules/locale/locale.compare.inc
   @@ -91,6 +85,7 @@ function locale_translation_build_projects() {
   +      'name' => $name,
   

   Do we really need name? as the name is already the *key*?

2. +++ b/core/modules/locale/locale.translation.inc
   @@ -329,13 +327,15 @@ function locale_cron_fill_queue() {
   +  $projects = array_filter($projects, function($project) {
   +    return $project['status'] == 1;
   +  });
   

   is it overkill to ask \Drupal::service('locale.project)->getAllActive() ?

As those two are minor/improvements, +1 to RTBC.

1. +++ b/core/modules/locale/locale.compare.inc
   @@ -102,17 +97,7 @@ function locale_translation_build_projects() {
   -    db_merge('locale_project')
   -      ->key('name', $project->name)
   -      ->fields(array(
   -        'name' => $project->name,
   -        'project_type' => $project->project_type,
   -        'core' => $project->core,
   -        'version' => $project->version,
   -        'server_pattern' => $project->server_pattern,
   -        'status' => $project->status,
   -      ))
   -      ->execute();
   +    \Drupal::service('locale.project')->set($project->name, $data);
   

   Prior code has $project, new code has $data, is this doing what the prior code did?

2. +++ b/core/modules/locale/locale.translation.inc
   @@ -57,8 +57,7 @@ function locale_translation_get_projects($project_names = array()) {
   -    $row_count = db_query_range('SELECT 1 FROM {locale_project}', 0, 1)->fetchField();
   -
   +    $row_count = \Drupal::service('locale.project')->countProjects();
   

   Prior code was not an actual count, new code is an actual count, yay :)

#26.1 - Yes, it has data already for other purposes:

    $data += array(
      'name' => $name,
      'version' => isset($data['info']['version']) ? $data['info']['version'] : '',
      'core' => isset($data['info']['core']) ? $data['info']['core'] : \Drupal::CORE_COMPATIBILITY,
      // A project can provide the path and filename pattern to download the
      // gettext file. Use the default if not.
      'server_pattern' => isset($data['info']['interface translation server pattern']) && $data['info']['interface translation server pattern'] ? $data['info']['interface translation server pattern'] : $default_server['pattern'],
      'status' => !empty($data['project_status']) ? 1 : 0,
    );
    $project = (object) $data;

that's why we have $project-> on the query.

#26.2 - Yeah, it's much clear now. DX++

Thanks @vijaycs85 my concerns were unfounded there. While this can be improved later on, it is already a good step, yup :)

Looks like good clean-up.

Committed and pushed to 8.x. Thanks!

More D8-like code++ Yay, thanks!

Follow-up: #2834580: Move locale.translation_status state key to a separate key/value collection