Closed (fixed)
Project:
Currency
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
17 Oct 2007 at 17:47 UTC
Updated:
25 Mar 2013 at 00:45 UTC
Jump to comment: Most recent file
I'm the maintainer of the Money CCK field module and one of the feature requests is support for currency symbols. While this is obviously a good thing to support, I think the right level to support this, is the Currency API module. After all, this module provides the list of currencies as well (currency_api_get_list()).
Would a patch that added a currency_api_get_symbol() function be accepted?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | currency_symbols.patch | 10.09 KB | wim leers |
Comments
Comment #1
wim leersFor the record, this site provides a list of pretty much every currency symbol. And on Mac OS X Tiger at the least, all of them except AFN (Afghanistan) and UAH (Ukraine) render properly.
Comment #2
kbahey commentedWim
I have been watching your contributions for a while, and because your history speaks for you, I granted you commit access to the CVS of the currency exchange module.
Go ahead and commit any new features you want, just keep me informed, and don't break backward compatibility.
Enjoy.
Comment #3
wim leersWhat can I say? Thank you very much for the compliment! :) And thanks for the commit access.
I'll post the patches in the issue queue first, but as I understand it, I don't have to wait for you to review them?
Comment #4
wim leersSeveral currencies were either no longer in use, or new ones had replaced them. Others were simply missing.
In the case of metals (gold, silver, etc.), I've simply kept the 3-letter codes. When there were different signs for singular and plural, I opted for the plural one.
For one currency (Afghanistani Afghani), there is no glyph included in Unicode yet, instead I chose "afghani" as the symbol (since there are no directions whatsoever).
For another one (Ukrainian Hryvnia), there is a Unicode glyph, but it's only available on the newest systems. Here I chose for the previously used notation: "грн.".
Finally, there are two non-decimal currencies (Madagascar's and Mauritania's) and one extremely unique notation (Tanzanian Shilling).
All special cases have comments.
Since there are some edge cases, I'm going to wait for your consent before committing this.
Comment #5
kbahey commentedLooks good.
Go ahead and commit it to 5.x and HEAD.
Comment #6
wim leersCommitted!
Comment #7
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #8
kenorb commentedWhat happened to currency_api_get_list() function ?
Where is the alternative?
Comment #9
xanohttp://drupal.org/node/1945330