Here's the error I get when starting or stopping the timer.

* warning: Invalid argument supplied for foreach() in /homepages/29/d102833726/htdocs/drupal/modules/node/node.module on line 521.
* warning: implode() [function.implode]: Bad arguments. in /homepages/29/d102833726/htdocs/drupal/modules/node/node.module on line 525.
* user warning: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM studiosgh_node n INNER JOIN admin_users u ON u.uid = n.uid INNER JOIN studiosgh_node_revisions r ON r.vid = n.vid WHERE in /homepages/29/d102833726/htdocs/drupal/includes/database.mysql.inc on line 172.

CommentFileSizeAuthor
#1 start_stop_clock_01.patch3.64 KBsanduhrs

Comments

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Assigned: Unassigned » sanduhrs
Status: Active » Needs review
StatusFileSize
new start_stop_clock_01.patch3.64 KB

I'm not shure what the reason was for this.
A little code refactoring solved the problem.
Patch attached, please review.

robertgarrigos’s picture

robertgarrigos commented

I couldn't reproduce this error with latest .dev version of this module and drupal 5.5. Could you give me some more info on how to reproduce it? thanks

robertgarrigos’s picture

robertgarrigos commented
Status: Needs review » Postponed (maintainer needs more info)
sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented

I just tried to reproduce it myself and found, that I couldn't - until I switched on case_tracker.module v5.x-1.1.
So it's possibly a bug in there.

Nontheless I think it's not a bad idea to remove the logic from the forms, as I suggested in my patch.
vg

robertgarrigos’s picture

robertgarrigos commented

I just realize of that while reviewing another issue.

robertgarrigos’s picture

robertgarrigos commented
Status: Postponed (maintainer needs more info) » Needs review
robertgarrigos’s picture

robertgarrigos commented
Status: Needs review » Fixed

commited to HEAD. thanks

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.