patch to convert comment-wrapper.tpl.php to comment-wrapper.html.twig

CommentFileSizeAuthor
comment-wrapper.patch4.54 KBsonictruth

Comments

jenlampton’s picture

jenlampton
she / her
commented
Status: Needs review » Postponed

Postponing until we decide the comment-wrapper template is done.

I'm also not sure about removing any of the the tpl.php files yet, since Bartik still uses PHPTemplate and not Twig for it's engine - committing this patch would break our sandbox. We'll need to replace all the templates in Bartik with one patch, when the time comes :)

thedavidmeister’s picture

thedavidmeister commented

The bartik tpl.php files cause the testbots to fail for the comment module as the new preprocess functions are incompatible with them - see the failed tests in comment #4 of #1898054: comment.module - Convert PHPTemplate templates to Twig.

Since the converted tpl.php files from Bartik would be identical to the core template files and there is nothing being "overridden" per-se by bartik I removed the Bartik templates altogether in my patch there.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1750250)