drupal_get_html_head() should not call drupal_render [#1843708]

Problem/Motivation

Since the process layer is being removed from Drupal 8, we need to move the addition of $variables['head'] from the process layer to the preprocess layer. But no variables in preprocess should be rendered, they all need to exist in their renderable state, and should only be rendered later, at the time they are inserted into the templates. Because of this drupal_get_html_head() needs to return a renderable, not rendered output.

Proposed resolution

Code change as follows:

function drupal_get_html_head() {
  $elements = drupal_add_html_head();
  drupal_alter('html_head', $elements);
  return $element;;
}

Remaining tasks

- if necessary, add a equivalent __toString method to the renderable object.

User interface changes

None.

API changes

TBD.

#1843710: Remove template_process_maintenance_page()
#1843704: Remove template_process_html()
#1843650: Remove the process layer (hook_process and hook_process_HOOK)
#2004286: Defer calls to drupal_get_* functions until printed inside a template by adding a RenderWrapper class

Comment	File	Size	Author
#4	common-no_drupal_render_in_drupal_get_html_head-1843708-4.patch	398 bytes	pmelab

Comments

Comment #0.0

jenlampton

she / her

commented 18 November 2012 at 00:28

Issue summary:

View changes

related issue

Comment #1

gnuget

Spanish

commented 22 April 2013 at 21:49

Assigned:

Unassigned

» gnuget

Comment #2

gnuget

Spanish

commented 24 April 2013 at 07:43

i checked this issue, and i'm not sure what to do.

Since the preprocess is for renderable variables i'm not sure where should be render the content of the drupal_get_html_head().

I did a quick "grep" into the core and seems to drupal_get_html_head() is mainly used in:

template_process_html
template_process_maintenance_page

(there are other few places where is used drupal_get_html_head() but my doubts are related with these two templates)

if i make the change suggested in the drupal_get_html_head() function (remove the drupal_render) and put the $variables['head'] = drupal_get_html_head(); at the preprocess where should be rendered the content of the head? directly at the html.tpl.php?