Download & Extend
Issues

[meta] Convert views module to Twig

Posted by tostinni on November 18, 2012 at 1:58am
Project:Drupal core
Version:8.x-dev
Component:views.module
Category:task
Priority:normal
Assigned:Unassigned
Status:active
Issue tags:Twig, VDC

Issue Summary

Some patches have been rolled against the Drupal 8 Twig sandbox, and some Views patches have been committed to the sandbox. In our effort to get these patches/commits out of the sandbox and into core, follow each of the linked issues to find the status of work in the sandbox including preprocess funtions in views module files and/or .html.twig files in core/themes/stark/templates/views/.

.html.twig files need to be in core/modules/views/templates, with any existing templates moved out of core/themes/stark/templates/views.

Remaining

Template file conversions

Theme function conversions

#1898472: [meta] Convert views_ui module to Twig
#1757550: [meta] Convert core PHPTemplate files and theme functions to Twig

Login or register to post comments

Comments

#1

Posted by joelpittet on November 18, 2012 at 9:10am
Status:active» needs work

This is rough patch of all the views (not views_ui because didn't know the path they should go to)

Some of this may be better than others, but may give someone a headstart.

AttachmentSizeStatusTest resultOperations
views-to-twig-rough.patch17.64 KBIgnored: Check issue status.NoneNone

#2

Posted by joelpittet on November 22, 2012 at 9:19pm

All patches were moved to their respective non-meta issues.

#3

Posted by dawehner on November 24, 2012 at 10:29am

Please tag everything related with views with VDC, so people can find it.

#4

Posted by mbrett5062 on December 17, 2012 at 4:58pm

Have now tagged all the separate issues with VDC as per #3.

#5

Posted by FluxSauce on January 27, 2013 at 12:20am

I've started committing these as part of #1898470: [meta] Convert views module to Twig at SANDcamp 2013. My apologies now for some of the messy commits - joelpittet has done a fantastic job, among many others.

#6

Posted by c4rl on January 27, 2013 at 3:41pm

My apologies now for some of the messy commits

Can you explain why you are committing issues that were marked "needs review" and not yet marked "reviewed & tested by the community?"

#7

Posted by steveoliver on January 27, 2013 at 7:41pm

I had him commit directly and we should have stuck to posting patches.

#8

Posted by damiankloip on January 30, 2013 at 7:50am

Are we going to get a proper issue for these? We don't get too much exposure to these and I definitely want to review them before they get committed, rather than being committed in one super patch.

#9

Posted by c4rl on January 31, 2013 at 4:45pm

Are we going to get a proper issue for these?

@damiankloip #8 As discussed just now in IRC, we'll plan to move the linked issues above to the core queue so that we don't submit a super patch.

#10

Posted by c4rl on January 31, 2013 at 4:45pm
Issue tags:+Twig

Tagging

#11

Posted by steveoliver on February 11, 2013 at 4:48pm
Title:[META] Views conversion to Twig» [META] Convert views module to Twig
Project:Drupal 8 Twig Sandbox» Drupal core
Version:<none>» 8.x-dev
Component:Twig templates conversion (front-end branch)» views.module
Status:needs work» active

Moving this to the core queue, marking #1898470: [meta] Convert views module to Twig as duplicate.

#12

Posted by steveoliver on February 11, 2013 at 4:51pm
Title:[META] Convert views module to Twig» [meta] Convert views module to Twig

#13

Posted by Cottser on April 15, 2013 at 4:38pm

As discussed with @dawehner we will remove @ingroup views_templates from all Views and Views UI .html.twig templates. If you are working on patches on any of the sub-issues that have this line in the template(s) it would be a huge help if you can reroll to remove that line. Thanks!

nobody click here