Posted by Crell on November 18, 2012 at 6:10am
7 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | system.module |
| Category: | task |
| Priority: | critical |
| Assigned: | Crell |
| Status: | closed (fixed) |
| Issue tags: | WSCCI |
Issue Summary
Another easy conversion, this patch moves the cron "page" callback to a controller. It also inlines the access check until #1793520: Add access control mechanism for new router system happens.
Patch coming as soon as I have a nid...
Comments
#1
#2
+++ b/core/modules/system/lib/Drupal/system/CronController.php@@ -0,0 +1,55 @@
+ * A
I think this was a typo or a statement that was never finished.
Other than that, the patch looks good architecturally. It's nice and simple. The YAML routing file to specify what controller to run, and a direct port of the current cron code to that controller.
#3
+++ b/core/modules/system/lib/Drupal/system/CronController.php@@ -0,0 +1,55 @@
+ /**
+ * Run Cron once.
+ *
+ * @return Symfony\Component\HttpFoundation\Response
+ * A
+ */
Ayup, I forgot to finish filling that in because I wasn't sure what to say. :-) If you want to reroll with revised text there I can RTBC it. (I won't be able to do so until tonight, so whoever gets to it first, do so.)
#4
New patch, just fixes the doc.
#5
#6
The denizens of #drupal-contribute suggested making this critical, since it's a procedural blocker for #1793520: Add access control mechanism for new router system, which is also critical. (That issue needs an existing new-style for-reals route to convert, which this issue provides us.)
#7
Committed to 8.x. Glad to see some new routing action. Thanks!
#8
Automatically closed -- issue fixed for 2 weeks with no activity.