Posted by Wim Leers on October 17, 2007 at 8:59pm
Jump to:
| Project: | Nodecarousel |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | jcfiala |
| Status: | closed (fixed) |
Issue Summary
Please create a dependency on the jCarousel module, probably also on jQuery Update and remove the included version of jCarousel and jQuery 1.2.1. That prevents double inclusion of the jCarousel JS files and more importantly a double inclusion of jQuery itself.
Comments
#1
There is a dependency on the jQuery Update module, but I added a note to the page to list that.
I plan to update it to depend on the jCarousel module as soon as it's updated to the latest version. (Yes, Wim and I have talked directly, I'm just putting the note here for anyone else who comes by and wonders.
#2
This is now fixed - the dependencies are clearly marked on the page and in the module. Additionally, the dependency is now on jCarousel directly, which requires jQuery on it's own.
#3
You should know that I'm making the move to a single module for all carousel stuff: http://drupal.org/project/carousel. As soon as everything has been moved to that module, you should update the dependency. I'll of course leave the jCarousel module online for a decent amount of time after that.
I'm not sure you'll want to, but it doesn't hurt to offer: would you agree to putting nodecarousel also in this single carousel module? Then it'll have support for:
- nodequeue
- panels
- views
There's already 1 other maintainer: Rob Loach. If you'd agree to merge, we'd be with 3 maintainers, so that'll definitely be beneficial. You can of course keep the credits for this module.
#4
Making sure you see this.
#5
This project is dead.
I want this out of my list of issues.