Notice: Undefined property: stdClass::$teaser in stormteam_list() (line 606 of /srv/bindings/8db7e47a01064d9a9a1eac5218b9b05c/code/sites/all/modules/storm/stormteam/stormteam.module).

This is because the body field is now a field in Drupal.

CommentFileSizeAuthor
#27 stormteam-viewslistmenuentry-1844048-comment27.patch768 bytesesoteric1
#7 storm-team-list-views-6.patch14.77 KBjuliangb
#5 storm-team-list-views-3.patch7.86 KBjuliangb
#3 storm-team-list-views-2.patch7.86 KBjuliangb
#1 storm-team-list-views.patch7.39 KBjuliangb

Comments

juliangb’s picture

juliangb commented
Title: PHP error on viewing team list » Use Views for Storm Team list
Status: Active » Needs review
StatusFileSize
new storm-team-list-views.patch7.39 KB

I realised that we're going to run round in circles porting fairly custom code for the lists, when we could just go straight into views.

I fully expect that there will be some refinement of this, but it will save a lot of time to go straight into views now.

Status: Needs review » Needs work

The last submitted patch, storm-team-list-views.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm-team-list-views-2.patch7.86 KB

Looks like the test also now needs to enable the views module.

Status: Needs review » Needs work

The last submitted patch, storm-team-list-views-2.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm-team-list-views-3.patch7.86 KB

Not sure why it is still failing - but this patch includes the new default view (forgot to git add).

Status: Needs review » Needs work

The last submitted patch, storm-team-list-views-3.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm-team-list-views-6.patch14.77 KB

Getting the patch right this time I hope.

Status: Needs review » Needs work

The last submitted patch, storm-team-list-views-6.patch, failed testing.

esoteric1’s picture

esoteric1 commented
Status: Needs work » Needs review

#7: storm-team-list-views-6.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, storm-team-list-views-6.patch, failed testing.

esoteric1’s picture

esoteric1 commented
Status: Needs work » Needs review

When I downloaded the patch, applied it and ran it through the drupal testing on my dev installation there were 326 tests run but on this site there are 320 run. is there a reason for the difference?

juliangb’s picture

juliangb commented

The difference is probably the ones that have failed here.

Not sure why they have failed at the moment, but we should ensure that they pass before committing the patch so that we keep building up the suite of automated tests.

juliangb’s picture

juliangb commented

#7: storm-team-list-views-6.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, storm-team-list-views-6.patch, failed testing.

juliangb’s picture

juliangb commented

I've created a support request in the testbot queue, as I think this is a case of needing a specific procedure for the testbot to recognise the dependency.

#1844686: Test failure on new dependency.

esoteric1’s picture

esoteric1 commented

Does the views integration work atm? should I go through the other modules and put similar fixes?

juliangb’s picture

juliangb commented

Yes, that'd be useful - thanks!

esoteric1’s picture

esoteric1 commented

If you make comments in the code you write from now on, I don't mind going through and applying through the changes to the other modules and writing the patches. It's a sort of learning thing for me, and since I am a new developer it helps a great deal to have those comments. I'll get started today and work on it tomorrow as well.

esoteric1’s picture

esoteric1 commented

Also want to confirm that its the storm-patch6 that i should be using as a reference?

juliangb’s picture

juliangb commented

The easiest method is actually to build the view with the views ui, then to export, with the lines at top and bottom as per the default view file.

It means that the writing of the code becomes fairly minimal.

I'm still following up to get drupal.org to pass the tests again.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review

#7: storm-team-list-views-6.patch queued for re-testing.

juliangb’s picture

juliangb commented

Branch tests now pass with views in, so *fingers crossed* nothing to stop this from passing.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Tests passed - just pushed this into git.

esoteric1’s picture

esoteric1 commented
Status: Fixed » Needs work

I no longer see the teams submenu in the navigation menu after this change. Is this intended?

juliangb’s picture

juliangb commented

Hmm, yes I see what you mean.

Thinking about it, I'm actually pro getting rid of the links as it is easy for the site owner to do this - but it is something we should decide on one way or the other rather than it just happening.

esoteric1’s picture

esoteric1 commented

I think you can just specify a normal menu entry in the views configuration and then people can remove it from there if they want. I believe that would make sense?

esoteric1’s picture

esoteric1 commented
Status: Needs work » Needs review
StatusFileSize
new stormteam-viewslistmenuentry-1844048-comment27.patch768 bytes

made a small patch to add the menu entry through the view for stormteam.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Not time to do much tonight, but have committed #27. Thanks @esoteric1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.