In some cases Notice: Undefined index: yandex_metrics_reports in chart_unique_color() (line 1211 of sites/all/modules/contrib/chart/chart.module). appears.

Patch with fix attached. Port to other branches is needed.

CommentFileSizeAuthor
yandex_metrics-chart-notice-fix.patch754 byteskalabro

Comments

Konstantin Komelin’s picture

Konstantin Komelin commented

Thank you, kalabro!

Congrats! Now you have write access to the project VCS and fell free to commit this patch by yourself.

Just remember some rules:
1) Discuss your changes with others
2) Care about your users
3) Follow DCS (codding standards)
4) Something that I could forget ;)

kalabro’s picture

kalabro
she/her
commented

Amazing news, Konstantin!
Commited this patch as it is to 7.x-2.x and 6.x-2.x.
Please, review and inform if something went wrong.

Should I also backport it to 1.x version?
http://drupalcode.org/project/yandex_metrics.git/blob/refs/heads/6.x-1.x...
http://drupalcode.org/project/yandex_metrics.git/blob/refs/heads/7.x-1.x...

Konstantin Komelin’s picture

Konstantin Komelin commented
Status: Needs review » Needs work

Thanks, Kate!

One thing we should always remember is to add records into the CHANGELOG.txt.

I added records for your recent changes here:
http://drupalcode.org/project/yandex_metrics.git/commit/ec8a181
http://drupalcode.org/project/yandex_metrics.git/commit/e02c79e

Your commits look good, please port them to the 1.x branches.

kalabro’s picture

kalabro
she/her
commented
Status: Needs work » Fixed

Done!
http://drupalcode.org/project/yandex_metrics.git/commitdiff/refs/heads/7...
http://drupalcode.org/project/yandex_metrics.git/commitdiff/refs/heads/6...

Konstantin Komelin’s picture

Konstantin Komelin commented

Fantastic contribution! Keep it up!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.