Hi there, we have a 336x280 pixel adsense block injected in the middle of our content, and after upgrading to Corporate Clean 7.x-2.0, the adsense block is getting its HEIGHT cut off.

Please help!

Thanks!

Comments

gtsopour’s picture

gtsopour commented
Assigned: Unassigned » gtsopour
Status: Active » Needs review

Hello,
please edit your style.css (sites/all/themes/corporateclean/style.css) and make the following change at the bottom of your stylesheet:

Change from 

/**
 * Responsive embed, object, iframe
 */
embed, object, iframe { width: 100%; height: auto; }

To

/**
 * Responsive embed, object, iframe
 */
embed, object, iframe { max-width: 100%; height: auto; -webkit-box-sizing: border-box; -moz-box-sizing: border-box; box-sizing: border-box; }

I will commit this fix immediately.

Thanks
/George

mntash’s picture

mntash commented

Thanks... I made the change but am still having the issue :(

Zwappe’s picture

Zwappe commented

This is according to me related to the same problem I have/had, see here

Instead of height: auto; I used max-height:100%; then it should work, but I still wonder why the height: auto; does not work...

mntash’s picture

mntash commented

Zwappe: thank you very much for your suggestion. Changing height to 100% worked for me!

Should I use max-height: 100% or should I use height: 100% ?

Right now I am using just height: 100% and it seems to work. I will look for other side effects..

Zwappe’s picture

Zwappe commented

Hey,

I'm glad it helped you out!

I think that in this case it doesn't matter if you use max-height or just height, because there is no height defined in the theme (unlike with the width). So in that case both of them would mean almost the same. I'm not 100% sure of this, maybe gtsopour can answer this?

gtsopour’s picture

gtsopour commented
Priority: Normal » Critical
Status: Needs review » Active
gtsopour’s picture

gtsopour commented
Status: Active » Fixed

Remove custom width/height definitions for embed, object, iframe - http://drupal.org/node/1900134

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.