Features:
1. Allows you to accept payments through the LiqPay payment system.
2. It is possible to view the incoming payments.
3. Keeps a log of requests from the payment system.

Fields of application:
1. Acceptance of donations
2. Online shopping.

Difference from "Liqpay payment gateway for Ubercart":
Does not require module Ubercart

Project page: http://drupal.org/sandbox/unflexible/1843646
Git: git clone http://git.drupal.org/sandbox/unflexible/1843646.git liqpay

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

Welcome,

please get a review bonus first. Then try to fix issues raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxunflexible1843646git

nesta_’s picture

nesta_ commented

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

README.txt is missing, see the guidelines for in-project documentation.
Remove "version" from the info file, it will be added by drupal.org packaging automatically.

parwan005’s picture

parwan005 commented

Hi,

here are my suggestions after doing manual review of your code:-

1) What is the need of line 89 when you are doing reset of value from theme_table just below one line.
2) In line number 97 i dont think parameter is form_state is required here.
3) In liqpay_index_validate instead of $form use &$form. Make it a practice as it is good practice as you get whole form content for validation along with &$form_state. Same thing applies to liqpay_index_submit function.
4) Also format of doxygen commenting has changed from Implementation of hook_requiredhook() to Implements hook_requiredhook. Please change this.
5) Make sure that each of you file ends with a new line.

Make sure your follow proper commenting of functions or variables as described here : http://drupal.org/node/1354

Also remove your master branch from repo and fix your ventral issues here: http://ventral.org/pareview/httpgitdrupalorgsandboxunflexible1843646git

Thanks
Parwan

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)