Whene editing a content type the "Hide translation links" setting is always showed, instead it should be visible only for entity translation enabled types.

CommentFileSizeAuthor
#4 et-node_hide_settings-1844844-4.patch2.43 KBbforchhammer
#2 et-hide_hide-1844844-2.patch3.49 KBplach
#1 et-hide_hide-1844844-1.patch760 bytesplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Title: Hide translation links always showed » "Hide translation links" setting always showed
Status: Active » Needs review
StatusFileSize
new et-hide_hide-1844844-1.patch760 bytes
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Title: "Hide translation links" setting always showed » Content type settings always showed
Priority: Minor » Normal
StatusFileSize
new et-hide_hide-1844844-2.patch3.49 KB

Hm, actually this should apply to all node-specific settings.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Component: Base system » User interface
bforchhammer’s picture

bforchhammer commented
StatusFileSize
new et-node_hide_settings-1844844-4.patch2.43 KB

I think it would be good to do this via the form states api... achieves the same effect visually, but it doesn't require that the form is saved before showing advanced settings to the user.

What do you think, plach?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Fixed

Definitely better :)

Committed and pushed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 74e6d99 on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions authored by bforchhammer, committed by plach: 
    Issue #1844844 by plach, bforchhammer: Fixed Content type settings...

  • Commit 74e6d99 on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions, workbench authored by bforchhammer, committed by plach: 
    Issue #1844844 by plach, bforchhammer: Fixed Content type settings...