If the user is using an adblocker to block the service, or if the ShareThis servers were to go down, then it should not interrupt other JS on the page. This is currently not the case - we get a 'stLight is undefined' error.

Patch forthcoming

CommentFileSizeAuthor
#4 sharethis-js_undefined-1845134-4.patch900 bytesjerenus
#2 sharethis_js_undefined_1845134_2.patch648 bytestimfernihough
#1 sharethis_js_undefined_1845134_1.patch931 bytesdalin

Comments

dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented
Status: Active » Needs review
StatusFileSize
new sharethis_js_undefined_1845134_1.patch931 bytes
timfernihough’s picture

timfernihough commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new sharethis_js_undefined_1845134_2.patch648 bytes

@dalin,

I've downloaded and tested this and works well, marking RBTC.

In my case, I'm working with a responsive theme that relies heavily on Javascript to function and we are finding that the client this project is for has an audience with very high security settings in their browsers and in some cases it prevents ShareThis from loading. This cascades and causes the entire theme to break as a result because of the stLight error.

I had to modify it to work with the most recent stable version (7.x-2.5) as that is what we're using in our install profile, so I've uploaded a second patch here for anyone who may need it for their make file.

jerenus’s picture

jerenus commented
Status: Reviewed & tested by the community » Needs work 
 ~/sharethis $ patch -p1 < sharethis_js_undefined_1845134_1.patch 
patching file sharethis.module
Hunk #1 FAILED at 473.
1 out of 1 hunk FAILED -- saving rejects to file sharethis.module.rej
jerenus’s picture

jerenus commented
StatusFileSize
new sharethis-js_undefined-1845134-4.patch900 bytes

Jslint's suggestion.

jerenus’s picture

jerenus commented
Status: Needs work » Needs review
robloach’s picture

robloach
he/him
commented
Status: Needs review » Reviewed & tested by the community

Looks good! I'll hopefully be able to commit today.

robloach’s picture

robloach
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks! https://drupal.org/commitlog/commit/5482/9fe4cdeb28f5471622a78aec81571ba...

jerenus’s picture

jerenus commented

Thank you for your encouragement. ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.