Hi,

I've created a module for masking parts of content for certain users, based on their roles or uids.
The module extends the shortcode module with a custom shortcode for defining the masking parts.

The module's sandbox can be found here;
http://drupal.org/sandbox/robinvdvleuten/1845578

The module's repository can be cloned like this;

git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/robinvdvleuten/1845578.git content_mask

Thanks in advance for reviewing!

Comments

parwan005’s picture

parwan005 commented
Status: Needs review » Needs work

Hi,

Here are the details after your manual review :-

1) rather than return '' in function you should use return;
2) function content_mask_shortcode_tips() is empty, you should remove it.
3) why $GLOBALS['user'] and not global $user ? When drupal is providing you the same thing why not use that?

Thanks
Parwan

robinvdvleuten’s picture

robinvdvleuten commented
Status: Needs work » Needs review

Hi Parwan,

Thanks for reviewing the module! I've incorporated your suggestions in the module.

robinvdvleuten’s picture

robinvdvleuten commented

I've included support for Organic Groups and the shorttag handling is now done by the module itself.

mohs3n71’s picture

mohs3n71 commented

you should copy your git clone link here not just the .git link
when i try to clone your code i see this error : Warning: remote HEAD refers to nonexistent ref, unable to checkout.
and i cant clone your code ...
please fix this

and also automatic review finds some issues in your code
you can see them from here : http://ventral.org/pareview/httpgitdrupalorgsandboxrobinvdvleuten1845578git

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

robinvdvleuten’s picture

robinvdvleuten commented

All minor issues detected by the automatic PAReview are removed:
http://ventral.org/pareview/httpgitdrupalorgsandboxrobinvdvleuten1845578git

asifnoor’s picture

asifnoor commented
Status: Needs review » Needs work

Did a quick manual review and here is one suggestion i have.

1. If possible, separate html from php code. (ref: content_mask_filter_tips)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Added the git clone link.