In JW Player 6 the filename of the flash player changed to jwplayer.flash.swf. This patch changes those filenames in the module. Maybe it would be better, to allow the user to change the paths in the admin settings page, to overcome future file renaming issues.

--> attention, after applying this patch, jwplayer5 won't work anymore.

CommentFileSizeAuthor
#19 jwplayer-6-1845744-19.patch4.48 KBsebas5384
#7 jwplayer-6-1845744-7.patch4.57 KBBerdir
#1 jw_player-jwplayer6_path.patch1.22 KBHopiu
jw_player-jwplayer6_path.patch1.22 KBHopiu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Hopiu’s picture

Hopiu CreditAttribution: Hopiu commented
FileSize
jw_player-jwplayer6_path.patch1.22 KB

oops, added the wrong filenames in the patch. sorry. here's the corrected one.

Juc1’s picture

Juc1 CreditAttribution: Juc1 commented

@ Hopiu thanks for this

http://www.longtailvideo.com/blog/29553/introducing-jw-player-6/

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
CreditAttribution: pingwin4eg commented

Is there any other changes in JW Player 6 that this module doesn't handle?

Hopiu’s picture

Hopiu CreditAttribution: Hopiu commented

Yes, there are some other changes. For example the handling of multiple file formats and quality levels. I have those adoptions running locally but I'm unsure about how to deal with playlists in general. (How were they intended to be implemented in this module? And how to distinguish between a playlist item and a file format / quality level)

Maybe some of the developers could give me a hint, so I could push the implement forward...

Thank you.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs work

Yes, this would break support with jwplayer5.

What I did to work around this issue is copy jwplayer.flash.swf to player.swf in the libraries folder. That works without patching the module.

A solution that could actually be commited would be a textfield that allows users to change the name of this field, with a description which name it is for jwplayer 6 and 5, probably default to 6 now. And an update function that sets it to the version 5 one + a message that there is a setting for this now.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Title: Change filenames to support jwplayer6 » Support JWPlayer 6
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review
FileSize
jwplayer-6-1845744-7.patch4.57 KB

Updated the patch to include a version setting, as suggested above.

Decided to go with a version setting, which is not quite as flexible, the reason for this is that we also need a workaround for http://developer.longtailvideo.com/trac/ticket/1833.

There are more things to be done, including the modes stuff.

Hopiu’s picture

Hopiu CreditAttribution: Hopiu commented

Thank you very much Berdir for your work!
How can we get those things into the dev version? (I think this patch won't even apply without this one: patch )

At least for me it's hard to keep the overview if we start to write patches depending on other patches.
(There's a lot to do for JWPlayer 6, I did quality switching and want to add playlists somehow, but would like to hear a maintainers opinion first)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Yes, the patch is currently to be applied after the premium key setting one. Which could be changed, but then they would conflict.

What you can do is mark the other issues as RTBC and confirm that they are ok and work for you. You could also get in touch with the maintainer, e.g. try it in IRC or through the contact form to see if they're still active and interested in improving this project. I think I've seen a relatively recent response from a maintainer somewhere. Asking for co-maintainership permissions would be another possibility, but I already have a ton of projects that I'm trying to maintain ;)

We could also create a temporary sandbox to make it easier to keep track of all the different required patches if all else fails but we should really try to avoid that. This project already is a fork of the original official project by the JW Player company. Let's not fork the fork :)

Max_Headroom’s picture

Max_Headroom CreditAttribution: Max_Headroom commented

Just a heads-up:
http://developer.longtailvideo.com/trac/ticket/1833
has been fixed on December 19, 2012
and will be rolled out with player 6.2

Max_Headroom’s picture

Max_Headroom CreditAttribution: Max_Headroom commented

I would suggest a new branch should be forked for a version specifically for JW6 and we can continue develop on that. The existing branch will then be kept in maintenance only for users that still user JW5.
It does not look like Longplay are going to maintain two versions.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I'm eagerly awaiting an update on this. I tried the patch against the latest dev but only 2/3 of the items worked. I really wish the version 5 player was still available, but it is not... so basically there is no path for using JW Player on new sites.

I will probably keep playing around with it but I'm thinking I have to tell my client we can't do this for now if I can't fix the patch.

Edit: I sorta got it working. It doesn't play my "mov" file in Firefox, but it shows up and works in Chrome. I tried the original patch, then the latest patch, ran database updates, saved the new settings page to use v6, and then adjusted my content type to set the field to use jwplayer.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

And mov's did work before with firefox? I think JW Player used flash as the default while JW Player 6 uses html5 and firefox probably has no codec for mov (I guess it is h.264?). We need to introduce a setting to change that.

I am not sure sure if a separate branch makes sense, because it will on the other hand mean more work for everything that has nothing to do with the jwplayer version, like integration wit more fields and so on.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

The file I was using, as it turns out, was not a "mov" but rather a h.264/AAC (aka, mp4) file. This is exactly the format that LongTailVideo recommends on their webpage.

Since I'm running on Linux, I am guessing that h.264 support is not built into my OS, which is how Firefox does h.264. It loads the Flash version of the player to get around this, but the player never fully loads, showing up only as a blank black screen.

When I open the console I get a JavaScript error that says type video/mp4 is not managed.

So I'm thinking it might have something to do with how I have the file entity module setup, or it might just be a problem with the Flash component. This thread seems to have some suggestions: http://www.longtailvideo.com/support/forums/jw-player/video-encoding/220...

Hopiu’s picture

Hopiu CreditAttribution: Hopiu commented

The file I was using, as it turns out, was not a "mov" but rather a h.264/AAC (aka, mp4) file. This is exactly the format that LongTailVideo recommends on their webpage.

MOV is a container format, h.264 is a codec. Means a .mov file can hold h.264 data, as well as a .mp4 file can.

Since I'm running on Linux, I am guessing that h.264 support is not built into my OS, which is how Firefox does h.264. It loads the Flash version of the player to get around this, but the player never fully loads, showing up only as a blank black screen.

Showing only as a blank black screen, happend to me when the player.swf couldn't be found. Try checking that the player.swf is loaded.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I'm still stuck on this. We downsized the file some more and moved the indexes to the front, so now it loads faster in Chrome but still not at all in Firefox... but I have made some progress.

When I read #15 I tried to use Firebug to adjust the URL of the Flash file, putting a fixed address helped. After looking at the rejected part of the patch in #7 above I noted the aggregation settings have an effect, so I disabled that. Now I get the Flash player loading, preserving the sites/all/libraries/jwplayer part.

Unfortunately though, the player loading doesn't seem to get the file. So it spins and spins but nothing ever gets downloaded. I'm still getting the following JS error (in French, but I will translate to English) :

L'attribut « type » spécifié sur « video/mp4 » n'est pas géré. Le chargement de la ressource média web.mp4 a échoué.

The attribute "type" specified as "video/mp4" is not managed. The download of the media file web.mp4 has been stopped.

And lastly, that reject patch... which seems to already be in the dev branch:

--- jw_player.module
+++ jw_player.module
@@ -390,7 +406,14 @@
   }
   // If inline is not selected, add all relevant JavaScript now.
   else {
+    // @todo: Convert this to a library.
     drupal_add_js(libraries_get_path('jwplayer') . '/jwplayer.js'); // Add library
+    if (variable_get('jw_player_version', 6) == 6) {
+      // @todo: The html5 js file needs to be added because it's not found when
+      //   aggregation is enabled. Update once
+      //   http://developer.longtailvideo.com/trac/ticket/1833 is fixed.
+      drupal_add_js(libraries_get_path('jwplayer') . '/jwplayer.html5.js');
+    }
     drupal_add_js(drupal_get_path('module', 'jw_player') . '/jw_player.js'); // Attaches JW Player element
     drupal_add_js(array('jw_player' => array($variables['html_id'] => $variables['config'])), 'setting'); // Player settings
koclup1580’s picture

koclup1580 CreditAttribution: koclup1580 commented

Maybe some of the developers could give me a hint, so I could push the implement forward.

Thank you so much.

Hopiu’s picture

Hopiu CreditAttribution: Hopiu commented

In reply to #16:
I still think there is a problem loading the .swf. The error you describe is thrown by Firefox, because it doesn't handle the "video/mp4" type. That's also why chrome is playing your file correctly (through HTML5).

See: Using HTML5 audio and video

Did you try setting "Flash primary, HTML5 failover" in your JWPlayer presets?

If you like, send me a message with a link to the page containing the player and I have a look at it.

To #17:
What I need most, is a clean way on how to integrate multiple video files in multiple formats in multiple qualities in playlists. If you have ideas on how to do that by still keeping the flexibility of having movies, files and links as field types I'd be very thankful...

sebas5384’s picture

sebas5384 CreditAttribution: sebas5384 commented
FileSize
jwplayer-6-1845744-19.patch4.48 KB

Thanks for the patch! just rerolled the patch against the dev branch.

Cheers!

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented

I have been looking at this and to support all the options available in JW Player 6 a lot more changes will be needed. V6 of the player also no longer uses plugins, and these features can be directly included in this module.

I am working on a full integration with JW Player 6 and would suggest a version 2 branch of this module to put it in.

greenwork’s picture

greenwork CreditAttribution: greenwork commented

I am glad I read this post before purchasing jwplayer 6. Not working in drupal currently is a big deal especially if people are going to spend 299$

Hopiu’s picture

Hopiu CreditAttribution: Hopiu commented

@dwkitchen:
I think too that it's the best way to create a version 2 for jwplayer 6. Leave me a message if you need help in any way.

@greenwe:
It's not that it doesn't work at all... You just won't be able to create playlists (although available through a patch) and quality- /mediatype- switching won't work. Beside those limitations, the player works quite well in my installation.

leanne9’s picture

leanne9 CreditAttribution: leanne9 commented

Glad to see there are people working on this, as I did in fact recently purchase the license for Premium, unaware of Longtail's lack of true support for Drupal. What is weird is the version 6 player worked just fine (didn't have to do anything but apply a patch to get the premium key in) for about a week, then stopped today (maybe in relation to either updating core or updating Video module?). I've sent Longtail an email, it's ridiculous to charge so much and provide no real Drupal support when the player has been out for a year.

Anyway, I did try to apply the most recent patch on this page, but it failed for me here:

Hunk #3 succeeded at 347 with fuzz 1 (offset -68 lines).
Hunk #4 FAILED at 459.
Hunk #5 succeeded at 414 (offset -70 lines).
1 out of 5 hunks FAILED

(I sincerely apologize if this is not the right way to post these things, I am still trying to learn the ropes).

Juc1’s picture

Juc1 CreditAttribution: Juc1 commented

Glad to see there are people working on this, as I did in fact recently purchase the license for Premium, unaware of Longtail's lack of true support for Drupal...I've sent Longtail an email, it's ridiculous to charge so much and provide no real Drupal support when the player has been out for a year.

@ leanne9 - please let us know what Longtail have to say. There was a user from Longtail involved with the Drupal 6 module = http://drupal.org/user/702586

deanflory’s picture

deanflory CreditAttribution: deanflory commented

Longtail is losing serious money by not updating the module with the JW Player 6 release, not sure how that is justified from a business perspective.

greenwork’s picture

greenwork CreditAttribution: greenwork commented

I talked to a guy from longtail. I am not sure what is going on with them atm but basically to sum it up they didn't make this module but I encouraged them to get involved :)

leanne9’s picture

leanne9 CreditAttribution: leanne9 commented

The steps taken up to this point: I emailed customer service, and the responding rep asked to see an example of where it wasn't working, and since our site is still protected, I could not send him that. I said it seemed to have something to do with "Aggregate and Compress CSS" in admin/config/development/performance and he said, "ok, yeah, i have never used that wp plugin before, but thats probably compressing our js in a way that it doesn;t like." So I said, "I will start over... there is not a Drupal module that supports JW Player 6. I have reverted to the version 5 player, but I cannot find a way to apply my license key to remove the logo on this player. Can you please provide some guidance as to how to do this?" So, he sent me a licensed version 5 player, which will do for now (now that I cleared my cache properly!), but I did ask him to pass on the message that the Drupal community would love to see more active involvment from Longtail.

deanflory’s picture

deanflory CreditAttribution: deanflory commented

I see they've now gone to a subscription model, and a pricey one at that: $99/year for the bare bones "Pro" plan for 1 commercial site; $299/year for the "Premium" 10 pack with Google Analytics and Social Sharing.

I think they're on the wrong track so I don't think they'll get involved until someone pays them "Enterprise" pricing to build it into a module for Drupal 7 and then they're not likely to update it at all.

Ho hum, sad really, all that effort to create the best player and then overpricing it. AND after all, it's only a video player and doesn't transcode or anything unless you buy into their BitsOnTheRun stuff that Drupal users don't need unless they can't run their own server.

Guessing this module dies with JWPlayer 5, leaving Drupal with no real video player that works well on many devices. Any Drupal gurus out there need a pet project? :))

greenwork’s picture

greenwork CreditAttribution: greenwork commented

So my solution was to make a content type with a default body encoding like they have on their site.

Using :

Tokens
Tokens filter

I created fields to update the tokens to my media link and a image file for my image that way it would be dynamically updated. I know this is a half fast solution but at least its working. The whole problem is the share functionality needs major customization to have your video playing on a separate page.

Used:
Custom theme with extra material removed
Themekey using the parameter to have my i frame display only the video

That was my solution for the time being. This module is great and I think everyone is on the right track. I will update all my nodes when this is going again.

The best option with the above method would have been a block but saddly the token [current-page:field_NAME] is not function yet but a request has been made for an update.

I would explore custom custom_formatters because using the default body option will cause you to remake the code across the board if you want to change the embed code. I am unsure if the custom formatters works with custom tokens atm.

Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander commented

This is more of an opinion than anything else, I can't fault Longtail for wanting to make money but it seems they should have built the paid model out soley with Bits on the Run. I can see why they are doing it though as JWPlayer has a well known name now that people know about.

That being said, I've actually had good luck with the Video module which comes with a native HTML5 ('Video for everybody' ) player and I've also used the video.js module in combo with the Video module with success also.

These are all good solutions for HTML5 with .mp4 video. In the rare cases, I need Flash video, I fall back on JW player 5 which is adequet but I've explained to my clients that MP4 / HTML 5 video is where it's at to be viewable on all devices. So in most cases, the native Video module HTML5 player is superb, simple, elegant and can be made responsive.

In cases where I need to embed youtube or Vimeo, their native payers are fine and responsive with the Video embed field module and fitvids.

greenwork’s picture

greenwork CreditAttribution: greenwork commented

I wanted a youtube overlay that allows embedding on other website options with backlinks to your website (not youtube). The native youtube player does not supply that functionality that gives your referring site credit.

deanflory’s picture

deanflory CreditAttribution: deanflory commented

One could also use the custom_formatters module to provide a way to use tokens within custom code, but it gets more complex when trying to do multiple files with multiple file types with multiple sizes in a playlist.

http://drupal.org/project/custom_formatters

Firefox I believe still does not support .mp4 MPEG-4 as the MPEG Group has the stipulation in the usage agreement that at any time they can begin charging commercial, for-profit entities for the usage of MPEG-4 playback, etc. Whether they'll ever do that or not is obvious unknown.

A year ago when I did in-depth research on compatibility with all players that were available at that time, JW Player was the only one that really served most without errors. Money vs. time vs. compatibility is the decision before me. It looks like the Video module is getting some long-needed love recently as well.

greenwork’s picture

greenwork CreditAttribution: greenwork commented

nice yes this would work better then my previous body default. Now I can format just the youtube url to display the video. Now if I want any changes to my videos I can change the format and not remake all the nodes.

I updated my previous post to reflect exploring custom_formatters. Thanks for the advice!

The only problem I can see is possibly http://drupal.org/node/1787132 but that would take further testing to see if this is effected.

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented
Title: Support JWPlayer 6 » JWPlayer 6 Support -> open 7.x-2.x Branch
Status: Needs review » Active

So I have been working on this over the weekend and forked on to github while I play around with getting it working. I hope that this work will lead to a v2 branch if one of the maintainers sees fit.

Here is my work so far: https://github.com/dwkitchen/jw_player

What's new:

Two new field field formatters

  • Sources - for a multi value field where the field contains quality variations of the same file.
  • Playlist - for a multi value field where the field contains multiple files to play as a playlist.

GetID3 integration

If enabled this module will add the dimensions of video to the file data, this will be used to pass the width and height data in the sources option. As an alternative (if using remote stream wrapper) will use data from field_width and field_height on the video entity type. These need to be added but I intend to make this configurable.

Thumbnail

If there is a field called field_video_thumbnail on the node it will use this as the thumbnail. I will make this configurable but would like some feedback on how people would use this.

Skins

Revised support for the new v6 skins and you can select one of the pro skins.

What's Gone

Plugins

JW Player 6 no longer supports plugins like 5 did so I have removed this functionality.

What's still to do

Old Plugins

Sharing, Recommended, Google Analytics are all included with v6 Player so should be included in this module.
There probably needs to be some way of adding custom JS extensions or functionality.

Configuration

Need to add configuration options for thumbnail etc.

Playlists

Possibly just an example of how to use a player with an RSS feed view or a custom view formatter for creating playlist players.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Hey everyone,

I'm still trying to get JW Player 6 to work in Firefox (on Linux). As noted above, I have resized, re-indexed, transcoded, followed every step in the LongTail docs to get the video file "just right". All versions give pretty much the same issues...

Currently it works everywhere but Firefox. I'm using "HTML5 primary, Flash failover" and "Inline JavaScript = FALSE".

The container is mp4, using h.264 w/ AAC audio, indexes at the front (though if indexes are missing, it works but just takes awhile).

Chrome loads the file and begins playing it as it buffers when it has indexes. In HTML5 video! Great.

Firefox loads the Flash player but I click play and nothing happens. On the console I see the following:

Error 1: Specified "type" attribute of "video/mp4" is not supported. Load of media resource http://pegasuspresentations.com/files/PegasusBriefing-SalesVersion1.1.mp4 failed.

Error 2: All candidate resources failed to load. Media load paused.

With error #1 I get referenced to line #45 in the JS file:

document.getElementById(h.id).getPluginConfig("display");"function"==typeof a.resize&&a.resize(c.width,c.height);b.style.left=c.x;b.style.top=c.h}catch(g){}}}function q(b){if(!b)return{};var d={},c=[],g;for(g in b){var e=a.getPluginName(g),f=b[g];c.push(g);for(var h in f)d[e+"."+h]=f[h]}d.plugins=c.join(",");return d}var k=new f.events.eventdispatcher,g=a.flashVersion();a.extend(this,k);this.embed=function(){b.id=h.id;if(10>g)return k.sendEvent(j.ERROR,{message:"Flash version must be 10.0 or greater"})

However, I don't get a version error event, and I'm running the current version of Flash for my OS (11+). Upon clicking play, nothing happens.

Media types are set to default "video" to use JW Player. Mime type correctly identifies as Video/MP4. This all looks good to me.

To see the error you can try the following files:
http://pegasuspresentations.com/media/42 (22.72 MB)
http://pegasuspresentations.com/media/45 (151.07 MB *probably without indexes).

Please note I'm using /files not /sites/all/files. So for the first file http://pegasuspresentations.com/files/PegasusBriefing-SalesVersion1.1.mp4 is where you will find it on the file system.

Any help would be appreciated. I've used JW Player before with no issues but this time around it has turned into quite a long process and only partial functionality. I'm at the point I'm considering just dropping this to use Vimeo's private hosted service.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Ok, I have one report of this video (see #35 above) working on Firefox/MacOS. I'm not using FlashBlock or AdBlock on the Linux machine, and Firefox plays video on other sites without issue. Any ideas?

Hopiu’s picture

Hopiu CreditAttribution: Hopiu commented

@dwkitchen:

How about creating a new field type?
The two new field formatters aren't solving the problem of having a playlist with several quality and/or filetype possibilities.

I think it makes sense to address this problem for the new 2.x branch. What do you think about it?

@Ryan Weal:
On OS X your videos are working in Firefox (Flash version of JWPlayer 6). I tried it on Ubuntu too, you have to install additional codecs. Have a look at https://help.ubuntu.com/community/RestrictedFormats/Flash.

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented

@Hopiu

I was thinking about a playlist field formatter for field collection or entity reference, where the reference entities would have a multi file field with the various sources. They could also supply the title, thumbnail etc. for the playlist if shown.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

@Hopiu thanks for taking a look. I am now convinced it *is* a codec issue, however I haven't found the specific package to install for Linux Mint Debian Edition (LMDE) yet. I will now be on the lookout for other "broken" sites, I was expecting the Flash version to work the same way the old one did... codecs included in the player package.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I've put more research into this bizarre issue I've been having with Firefox/Linux. It seems the player (Flash version) is attempting to use Apache's Range Request to get the file. That feature appears to have been disabled (by default) in Apache by a security update.

When requesting the files with in a Flash player I can see that I'm always getting a 206 error:

[14/Mar/2013:15:14:54 -0700] "GET /files/PegasusBriefing-SalesVersion1.1.mp4 HTTP/1.1" 206 23818409

So I guess I have some server config to do if this is going to be a self-hosted solution. I have seen a couple blog postings that point out http://drupal.org/project/resumable_download and http://drupal.org/project/xsendfile as possible ways to "offload" the file transfer process once Drupal is done with any preprocessing.

Alternatively it might be possible to re-enable Range Requets with the following in an Apache directory statement:

SetEnvIf Range (,.*?){5,} bad-range=1
RequestHeader unset Range env=bad-range

However, that did not seem to work for me.

This same issue occurs with other Drupal modules that do video and load a Flash-based player so I think this is the true cause of the issue I'm having.

I thought I was onto something with this post: http://www.longtailvideo.com/support/forums/jw-player/bug-reports/25739/... ... "The JW Player isn't making the byte range requests; the browsers' HTML5 video implementations are responsible. The browsers inspect non-sequential areas in the file for a variety of reasons, such as determining whether or not the video is playable in the browser, and to skip ahead to unbuffered regions in the video.

I get the 206 error immediately upon requesting the file using a Flash-based player.
If I link to the file directly - no problem - it just downloads fine and begins playing when it can. Argh!!

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented

Could I recommend that the sandbox 2.x version be posted as a development branch. I just installed it on my site and while there are still bugs, it works for the most part. This would allow for another development branch to be available on the issue queue and for others to post patches to help fix the bugs that still exist. It would also be worth noting on the project page that JW Player 6 does not work with version 1.x. I spent about an hour trying to troubleshoot before I figured out that this was my problem.

Thanks for your work on this. I'll be happy to test and help where my skills allow over the next few weeks.

rickvug’s picture

rickvug CreditAttribution: rickvug commented

@dwkitchen Thank you for your work on the JW Player module! I completely missed that you have a GitHub repo with many changes in it. I have given you full access to the project as you'll be a far more active maintainer than I.

I do ask that we take a few moments to catch up about the general direction, just as a quick sanity check for both of us. There's *a lot* that you've done. It would be good to have a review process in place as many of these changes are major and would benefit from peer review. I'm completely on board with the general direction, including a 2.x branch that only supports JW Player 6.

A few quick points to start:

  • It is a shame that the 2.x GitHub repo didn't start with a clone of the current repo. It is very difficult to track changes this way. For committing changes to the d.o. repo you'll need to create a proper branch. Also, LICENSE.txt shouldn't be in there.
  • Would it be possible to place work into multiple feature branches so that changes can be individually reviewed before merged into the 1.x or new 2.x branch?
  • A hard coded thumbnail field is not commit worthy IMO. We need something configurable. The thumbnail field could be attached to the file entity itself or to any other type of entity.
  • For sources (quality variations) I was thinking about integration with http://drupal.org/project/media_derivatives. Ideally Drupal would have a standardized way to track different quality versions of the same video file. From what I can tell this is the closest API that we have.

Thanks for all your hard work here!

- Rick

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented

Hi @rickvug,
Hope you are well.

The differences between JW Player 5 & 6 are big as well, hence the big changes to the module. I don't think there is any point in trying to get the 7.x-1.x working with JW6.

The I have only pushed the 2.x branch from the clone of the current d.o repo to GitHub, when I push it to d.o it will track all the changes from the 1.x branch. Not sure how the LICENSE.txt file got in there though.

As you say, a hard coded field is not the solution and I asked for opinions on how the thumbnail should be configured.

I have looked at Media Derivatives and it is not the solution for everybody, especially if you want to upload the variations rather than have the server create them for you.

rooby’s picture

rooby CreditAttribution: rooby commented

I would vote for the thumbnail field being a field on the file entity. I think that makes sense logically.

I haven't had a chance to look at the code yet but what about caption support?
Again, I would say that belongs on the file entity. Maybe a caption file upload field attached to the video file?

rooby’s picture

rooby CreditAttribution: rooby commented

It is kind of annoying that longtail themselves maintain the wordpress plugin, which has a v6 compatible version out now but they don't support drupal any more.

It is also really annoying how they have made their docs, plugins, info, etc. for old versions really hard to find.
I'm finding it impossibly hard to get the captions plugin for JW5 because everything keeps redirecting to the new and improved and unsupported JW6.

rooby’s picture

rooby CreditAttribution: rooby commented

@dwkitchen:

Any chance of you making your github project a drupal.org sandbox?

@rickvug:

Or maybe making a 2.x branch here in this project for it?

(sorry for the comment spam)

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented

@rooby, rickvug has given me access to the repo so I will push my code up this weekend.

It makes sense that the thumbnail is on the video itself, and the captions as you have mentioned. However it would be good to also have a formatter for the Media module so the thumbnail can be used in teasers etc. like the Media: YouTube module provides.

I have been thinking about how variants of the same media file can be handled, and it would be preferable that they are all handled by the same media entity. I have previously tried having a HD file field on the video file entity, but I didn't want the HD file to be another entity etc.

rickvug’s picture

rickvug CreditAttribution: rickvug commented

@dwkitchen Are Media thumbnails not controlled by the view mode on the file entity? If yes, then that becomes a configuration issue rather than any additional code.

As for variants, I agree that having a single video file entity is desirable. That is why I was thinking about http://drupal.org/project/media_derivatives, which (I would imagine) would create unmanaged file that would not become file entities in their own right. These unmanaged variants would be related back to the master file entity, which would contain all of the file meta data. Using the Media Derivatives API JW Player module would feed the variants into the JW Player theme function with the correct bit rates. This is an area that needs some work and I have not fully investigated but that was the roadmap. Personally I wish that there was more consistency and collaboration in this space. It sounds like we're hitting the bleeding edge of "doing Media right".

ibuildit’s picture

ibuildit CreditAttribution: ibuildit commented

m4v files work for me in mozilla, jw player 6 drupal 7, various patches

the problem was....wait for it... javascript aggregation.

when i disabled core js aggregation, jw player gracefully played the movie in flash while the other players play html5

greenwork’s picture

greenwork CreditAttribution: greenwork commented

Still active?

rickvug’s picture

rickvug CreditAttribution: rickvug commented

@greenwe When any of the committers have a patch to commit as the start of 2.x they are welcome to create the branch then. We've all agreed that the patch(es) for JW Player 6 support are what should be the start of the 2.x branch. Dev could start on a feature branch that becomes 2.x or the work could remain local, it really doesn't matter - Git makes branching very, very easy so creating the creation of a branch is a non-issue IMO.

The bigger issue is getting to the point where we have properly branched code that has added JW Player 6 support. I'm very happy and appreciative of @dwkitchen's work in the GitHub repo but unfortunately that didn't start as a clone of the current repo and all changes are together in the same place, making a feature by feature review more difficult.

rickvug’s picture

rickvug CreditAttribution: rickvug commented

@dwkitchen Hey, where did your repo go? I was going to quickly generate a diff as a starting point.

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented
Status: Active » Fixed

I have pushed the 2.x branch to the repo here now instead of GitHub.

I have closed this issue as the 2.x branch is now open and specific issues can be created against that.

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented
Status: Fixed » Active

For some reason, 2.x is not showing up under Versions when trying to create a new issue in the issue queue. That should probably be fixed before we close this issue.

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented

Sorry, I forgot you have to create a dev release for it to show up in the issue version list. Have done but it takes d.o a while to process it.

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented
Status: Active » Fixed

Looks like it's done and the version is there.

Thanks!

greenwork’s picture

greenwork CreditAttribution: greenwork commented

Thanks I see it on all versions but not on the front page. I appreciate all the work you guys are doing on this. longtail has lost its mind.

rooby’s picture

rooby CreditAttribution: rooby commented

It's probably best if it isn't on the home page right now if it isn't ready for mass consumption.

Otherwise you have a whole bunch of people telling you that things don't work that you already know about and are fixing.

If it is going to be in a better state soon I think keep it off the project page until then.

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented

@rooby. I would argue that it might be a good thing to have on the home page. Usually if it's a dev, people know that it's not ready for production and those who report issues are only helping. Even if it's a known issue, if it's not in the issue queue people don't know that it's being worked on and there isn't a place for status updates. If you want to avoid silly issues like "is 2.x stable" or something like that, just add a note to the home page on the development status of 2.x.

Just my 2 cents.

rooby’s picture

rooby CreditAttribution: rooby commented

Usually if it's a dev, people know that it's not ready for production and those who report issues are only helping

Unfortunately dev/beta/alpha/rc/unstable etc. is pretty much meaningless these days. I use tons of dev modules that work perfectly and have tried many a "stable" module that don't work.
I suppose it would be meaningful to have it on the project page as "dev" because it is in dev.

Even if it's a known issue, if it's not in the issue queue people don't know that it's being worked on and there isn't a place for status updates.

Good point.

You've swayed me :) (not that that matters :))

burningdog’s picture

burningdog CreditAttribution: burningdog commented

Not to get anyone's hopes up, but Longtail have said that they do intend on working on the drupal module now that the wordpress plugin is done: http://www.longtailvideo.com/blog/29553/introducing-jw-player-6#comment-...

I've pointed them in the direction of this thread...

rooby’s picture

rooby CreditAttribution: rooby commented

Help is always welcome at Drupal :)

Hopefully they help out here and don't do a competing module.

deanflory’s picture

deanflory CreditAttribution: deanflory commented

Please Longtail don't create a new module, work with this one and the Video module to get JW Player 6 compatibility on the Drupal 7 platform, please.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

drupaluser2012’s picture

drupaluser2012 CreditAttribution: drupaluser2012 commented

jw_player module still not working.

The link provided in README.txt file to download the 'latest commercial player' redirects to About Us page of the loingtailvideo site.

http://www.longtailvideo.com/players/jw-flv-player

Wondering that why people from longtailvideo.com not looking seriously into this issue. Hope they will look into this and provide the working JW Player 6 module with Drupal 7.

rooby’s picture

rooby CreditAttribution: rooby commented

Based on their efforts with the drupal 6 version of a jw player module I don't think Drupal is high up on their priority list.

They don't need to be involved anyway really, there are plenty of talented drupal developers that could do it, it's just a matter of them either having the spare time available or having someone to pay for development.

Since this issue is closed it is probably best top open a new issue and state which version of the module you are using.

If the link in the readme is wrong that is something that is very easily fixed.
Longtail's website has changed a lot recently so lots of old pages no longer exist.

If you go to the main page http://www.longtailvideo.com/jw-player/ there is a button that says "GET JW PLAYER". That's where you want to go.

greenwork’s picture

greenwork CreditAttribution: greenwork commented

I think they are moving away from a source based program to a more scripting cloud based situation. I can't blame them if they keep up with development but I am not going to pay for cloud solutions that I can not govern.