Insert Ads into View

Subscribing.

Attached is a patch that should get you off the ground. It does NOT yet support AJAX. I'm currently working on that.

Tested myself, but let me know how it goes.

Tim

Wow! This is very cool ... Thanks Tim. I cant wait to see it workin with AJAX :)

I know it looks like I changed *a lot* here, but really I just moved around a bunch of code, made some coding standards fixes, added some comments, etc... (see the interdiff to see what I changed) functionally I havent changed anything. I'm going to continue to play though.

Attached is a patch (based off your patch, bleen18) with AJAX support.

Critiques/Feedback welcome.

Tim

The only thing I see a problem with so far is that it violates Drupal policy to include a 3rd party JS library in a Drupal module. Can we instead add a link somewhere (maybe during install in a drupal_set_message() or if you try to turn on the ajax features or something like that)

ref: http://drupal.org/node/422996

This si really great though!! Thanks @breathingrock

Snugug,

Give this patch a try.

The DART module doesn't declare its own entity type, but I have separated the ads and nodes into their own rows. This ought to take care of your primary concerns. Tested with multiple blocks on a page (along with the same view for page content) and all look to be working independently from one another.

I didn't have time to debug the Views Load More issues. And I wouldn't think implementing a every-nth-row feature would be that difficult. I'll see what I can do about these tasks by next weekend.

@bleen18 - I'll work your idea re: the WriteCapture library in with the above stuff as well.

Tim

Snugug,

I could not reproduce this problem. Could it be an incompatibility with another custom/contrib module? I'm working on a clean Drupal install with only a standard set of contrib modules enabled.

I'm going to see what I can do about the every nth ad position.

Tim

And here's a patch with an option for setting an ad position interval, i.e. displaying an ad every nth row.

Tim

bleen - and here's the same patch as above that removes the writeCapture library from the module and warns the user if the writeCapture library isn't detected when editing the ad position settings in the view.

There is a minuscule whitespace issue, but otherwise this looks great to me... Lets give Snugug a chance to test drive it and then I think we're ready to commit.

timverly++

+++ b/dart.views.incundefined
@@ -0,0 +1,26 @@
+	'title' => t('Content with DART Ads'),
+	'help' => t('Display the node with standard node view, but with a dash of DART.'),
+	'handler' => 'views_plugin_row_dart_node_view',
+	'path' => drupal_get_path('module', 'dart') . '/views',
+	'theme' => 'dart_views_view_row_node',
+	'base' => array('node'), // only works with 'node' as base.
+	'type' => 'normal',
+	'uses options' => TRUE,
+	'type' => 'normal',
+	'help topic' => 'style-node',

white space issue...

Attached patch fixes the white space issue.

I uninstalled the WriteCapture library and couldn't replicate the JSON error. Not sure what could be causing it. Does everything point to this patch as the source of the problem on your end?

Btw, fixed the default interval values.

I've gotten past the previous roadblock

... did this require any changes in code?

breathingrock: do you follow #20? Can you reproduce

Not getting either the timeouts / slow page loads or the JSON.

Snugug: Could you provide a .tgz of your codebase and a DB dump so I can install on my local?

Here's a patch with postscribe support. Haven't re-tested writecapture yet.

And here we've got writecapture support, as well as support for the load ads last feature already implemented in the module. The 2 didn't necessarily play nice.

snugug mentioned that something might have been missing from teh views plugin yesterday.... has that been resolved?

Fixing up Views library detection error message and export variables.

And this a bit more proper version of the above patch.

And additional support for static tags with AJAX views paging.

+++ b/js/dart_tag_ajax.jsundefined
@@ -0,0 +1,108 @@
+      return tag.replace(/;ord=/, ';' + (top.__nbcudigitaladops_dtparams || '') + 'ord=');

Cant have nbcudigitaladops specific code here...

Removed the nbcudigitaladops conditional.

I got a RTBC from Snugug in IRC today ... WOOOOT.

Committed to HEAD ... the only change I made was moving dart.js and dar.admin.js into the new js folder

Thanks!!

Here is step-by-step tutorial how to insert custom code (adsense for example) after first and sixth row in your drupal 7 or drupal 8 views: http://www.jasom.net/how-to-add-custom-code-adsense-after-first-row-in-d...

Basically, you need to override your views-view-unformatted.tpl.php with this code

<?php if (!empty($title)): ?>
  <h3><?php print $title; ?></h3>
<?php endif; ?>
<?php foreach ($rows as $id => $row): ?>
  <div<?php if ($classes_array[$id]) { print ' class="' . $classes_array[$id] .'"';  } ?>>
    <?php print $row; ?>
  </div>
  <?php if ($id == 0 || $id == 5): ?>My custom code after first and sixth row in Drupal views<?php endif; ?>
<?php endforeach; ?>