It struck me that it might be a good idea to implement something similar to the node submission check: "This content has been modified by another user, changes cannot be saved.". Especially since some strings can be quite long.

The timestamp is stored so it should be possible to do that.

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Well, good idea, but we need to be smart about this. We need to keep what the user entered, especially if it is a long string, then present the updated translation from the other user and let the user decide on saving on top of it or not. As it stands now, all previous translations are kept, so data is not lost if someone overwrites an existing translation.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Closed (fixed)

Localization server D5 is not anymore available, so I close this here. Please open this again, if you have new information.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Active

Same issue applies to 6.x.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: "Modified by another user" » Check if translation was modified by another user

I think this should not be an issue for non-superadmins, since they can only submit suggestions, which are saved as new strings. So this looks like a very limited race condition at least with the default setup. Once you open up translation submission (vs. suggestion submission), this does become a bigger issue for sure.

SebCorbin’s picture

SebCorbin commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes

Bumping to 7.x, and might be related to #787068: Translate form re-building should not rely on pagination