Coming from #1824500-16: In-place editing for Fields:
@@ -0,0 +1,147 @@
+ // 'submit' in D8 is for "building the entity object", not for actual
+ // submission. It appears though that if there were no validation errors, it
+ // is submitted automatically.
+ field_attach_submit($entity->entityType(), $entity, $form, $form_state, $options);
1. I don't understand the second sentence of this comment. What exactly is happening automatically, and is that good or bad?
2. Please open an issue for us to rename field_attach_submit(), because in both HEAD, and here, it is called from within validation, and that is very confusing.
Add a @todo comment here linking to that issue.
And my explanation:
In D8, there is no actual submit handler, the EntityFormController stuff (or whichever class it is) takes care of that. IIRC,
field_attach_submit()(just maps the form values onto the entity object (see
field_attach_validate()validates the entity object itself, and if the EntityFormController notices there are zero validation errors, then it'll just save the entity object. No submit handler is involved at all. It took me a very long time to figure out this bizarre way of handling validation/saving. I'm sure it's just an artifact of the major changes that have been going on though :)
We need to fix this :)