Postponed (maintainer needs more info)
Project:
Cookie Control
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
21 Nov 2012 at 15:51 UTC
Updated:
25 Feb 2013 at 00:27 UTC
The JavaScript to initialize the cookiecontrol is in the .module file.
The syntax error is that the last item in the cookiecontrol init ends with a comma (,). In JavaScript you should not end with a comma, older IE versions will generate a script fault.
I added a patch to solve this issue. It also moves the javascript to an external file, using Drupal behaviors and Drupal settings.
| Comment | File | Size | Author |
|---|---|---|---|
| Syntax-error-in-JavaScript-and-incorrect-place-for-the-JavaScript.patch | 4.49 KB | michielnugter |
Comments
Comment #1
buddaThanks for the patch.
Already fixed in http://drupal.org/node/1922346
I'm not sure i'm a far of dumping clutter in to the Drupal.settings javascript for the sake of it though. Is there a benefit you can see?
Moving to the Drupal Behaviours model is a task to do though.