Problem/Motivation

This is part of #1446366: [meta] Multiple web test classes mislabeled as unit tests. simpletest ([Web|Unit|DrupalUnit]TestBase)

Wrong named classes were found using grep.
$ grep -r 'extends WebTestBase {' modules

SimpleTest WebTestBase classes don't fulfill tests coding standards https://www.drupal.org/node/325974. The definition is now closed, so we can rename according that.

Proposed resolution

  • Do a new search of simpletests classes that don't fulfill coding standards.
  • Rename the classes and files that don't fullfil standards.

Remaining tasks

  • Rename the classes and files that don't fullfil standards.

User interface changes

No.

API changes

No.

CommentFileSizeAuthor
#19 interdiff-1847280.12.19.txt1 KByesct
#19 simpletest-webtest-mislabeled-1847280-19.patch1.78 KByesct
#16 interdiff.1847280.12.16.txt676 bytesyesct
#16 simpletest-webtest-mislabeled-1847280-16.patch1.91 KByesct
#12 simpletest-webtest-mislabeled-1847280-12.patch1.78 KBbetoscopio
#11 simpletest-webtest-mislabeled-1847280-11.patch1.43 KBbetoscopio
rename-some-tests-classes.patch11.93 KBbetoscopio

Comments

yesct’s picture

yesct commented

Note the tests coding standards page is out of date and could use updating #1869794: Update tests coding standards doc and make consistant with 1354 where appropriate

yesct’s picture

yesct commented
Title: Rename some tests classes acording to code standards » Rename some functional SimpleTest WebTestBase test classes acording to code standards

they will have a use like:

use Drupal\simpletest\WebTestBase;

yesct’s picture

yesct commented
Issue summary: View changes

change a C in UnitTestCase to B as in simple test UnitTestBase. it's talking aout 974, so that is simple test stuff.

alansaviolobo queued rename-some-tests-classes.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, rename-some-tests-classes.patch, failed testing.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Issue summary: View changes
Parent issue: » #1446366: [meta] Multiple web test classes mislabeled as unit tests. simpletest ([Web|Unit|DrupalUnit]TestBase)

Parent issue added.

yesct’s picture

yesct commented
Issue summary: View changes

I dont remember what I was talking about in #2. :) We are working on this at a sprint together.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Issue summary: View changes

Updating summary, doing a new search of wrong named files.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Assigned: Unassigned » betoscopio
betoscopio’s picture

betoscopio
Primary language Spanish
commented
Issue summary: View changes

I have done a complete new search with grep finding wich are the subclasses of WebTestBase.
Inside the /core directory a looked using this:

$ grep -r 'extends WebTestBase {' modules

Then I got this full list of subclasses of WebTestBase

modules/search/src/Tests/SearchExcerptTest.php:class SearchExcerptTest extends WebTestBase {
modules/search/src/Tests/SearchTestBase.php:abstract class SearchTestBase extends WebTestBase {
modules/hal/src/Tests/FileDenormalizeTest.php:class FileDenormalizeTest extends WebTestBase {
modules/tour/src/Tests/TourTestBase.php:abstract class TourTestBase extends WebTestBase {
modules/menu_ui/src/Tests/MenuWebTestBase.php:abstract class MenuWebTestBase extends WebTestBase {
modules/menu_ui/src/Tests/MenuUninstallTest.php:class MenuUninstallTest extends WebTestBase {
modules/menu_ui/src/Tests/MenuNodeTest.php:class MenuNodeTest extends WebTestBase {
modules/help/src/Tests/HelpTest.php:class HelpTest extends WebTestBase {
modules/help/src/Tests/NoHelpTest.php:class NoHelpTest extends WebTestBase {
modules/filter/src/Tests/FilterNoFormatTest.php:class FilterNoFormatTest extends WebTestBase {
modules/filter/src/Tests/FilterDefaultFormatTest.php:class FilterDefaultFormatTest extends WebTestBase {
modules/filter/src/Tests/FilterHooksTest.php:class FilterHooksTest extends WebTestBase {
modules/filter/src/Tests/FilterFormatAccessTest.php:class FilterFormatAccessTest extends WebTestBase {
modules/filter/src/Tests/FilterAdminTest.php:class FilterAdminTest extends WebTestBase {
modules/filter/src/Tests/FilterHtmlImageSecureTest.php:class FilterHtmlImageSecureTest extends WebTestBase {
modules/filter/src/Tests/FilterSecurityTest.php:class FilterSecurityTest extends WebTestBase {
modules/filter/src/Tests/FilterFormTest.php:class FilterFormTest extends WebTestBase {
modules/contact/src/Tests/ContactPersonalTest.php:class ContactPersonalTest extends WebTestBase {
modules/contact/src/Tests/ContactAuthenticatedUserTest.php:class ContactAuthenticatedUserTest extends WebTestBase {
modules/contact/src/Tests/ContactSitewideTest.php:class ContactSitewideTest extends WebTestBase {
modules/ckeditor/src/Tests/CKEditorAdminTest.php:class CKEditorAdminTest extends WebTestBase {
modules/ckeditor/src/Tests/CKEditorLoadingTest.php:class CKEditorLoadingTest extends WebTestBase {
modules/ban/src/Tests/IpAddressBlockingTest.php:class IpAddressBlockingTest extends WebTestBase {
modules/locale/src/Tests/LocaleImportFunctionalTest.php:class LocaleImportFunctionalTest extends WebTestBase {
modules/locale/src/Tests/LocaleJavascriptTranslationTest.php:class LocaleJavascriptTranslationTest extends WebTestBase {
modules/locale/src/Tests/LocaleTranslatedSchemaDefinitionTest.php:class LocaleTranslatedSchemaDefinitionTest extends WebTestBase {
modules/locale/src/Tests/LocaleTranslationUiTest.php:class LocaleTranslationUiTest extends WebTestBase {
modules/locale/src/Tests/LocaleLibraryAlterTest.php:class LocaleLibraryAlterTest extends WebTestBase {
modules/locale/src/Tests/LocaleContentTest.php:class LocaleContentTest extends WebTestBase {
modules/locale/src/Tests/LocaleUpdateNotDevelopmentReleaseTest.php:class LocaleUpdateNotDevelopmentReleaseTest extends WebTestBase {
modules/locale/src/Tests/LocaleStringTest.php:class LocaleStringTest extends WebTestBase {
modules/locale/src/Tests/LocaleExportTest.php:class LocaleExportTest extends WebTestBase {
modules/locale/src/Tests/LocaleConfigTranslationImportTest.php:class LocaleConfigTranslationImportTest extends WebTestBase {
modules/locale/src/Tests/LocalePluralFormatTest.php:class LocalePluralFormatTest extends WebTestBase {
modules/locale/src/Tests/LocaleConfigTranslationTest.php:class LocaleConfigTranslationTest extends WebTestBase {
modules/locale/src/Tests/LocaleLocaleLookupTest.php:class LocaleLocaleLookupTest extends WebTestBase {
modules/locale/src/Tests/LocaleUpdateBase.php:abstract class LocaleUpdateBase extends WebTestBase {
modules/locale/src/Tests/LocalePathTest.php:class LocalePathTest extends WebTestBase {
modules/language/src/Tests/LanguageBlockSettingsVisibilityTest.php:class LanguageBlockSettingsVisibilityTest extends WebTestBase {
modules/language/src/Tests/LanguageBrowserDetectionUnitTest.php:class LanguageBrowserDetectionUnitTest extends WebTestBase {
modules/language/src/Tests/LanguageConfigSchemaTest.php:class LanguageConfigSchemaTest extends WebTestBase {
modules/language/src/Tests/LanguageConfigurationTest.php:class LanguageConfigurationTest extends WebTestBase {
modules/language/src/Tests/LanguageListModuleInstallTest.php:class LanguageListModuleInstallTest extends WebTestBase {
modules/language/src/Tests/LanguageNegotiationInfoTest.php:class LanguageNegotiationInfoTest extends WebTestBase {
modules/language/src/Tests/LanguageListTest.php:class LanguageListTest extends WebTestBase {
modules/language/src/Tests/LanguageConfigOverrideImportTest.php:class LanguageConfigOverrideImportTest extends WebTestBase {
modules/language/src/Tests/LanguageSwitchingTest.php:class LanguageSwitchingTest extends WebTestBase {
modules/language/src/Tests/LanguageUrlRewritingTest.php:class LanguageUrlRewritingTest extends WebTestBase {
modules/language/src/Tests/LanguagePathMonolingualTest.php:class LanguagePathMonolingualTest extends WebTestBase {
modules/language/src/Tests/LanguageConfigurationElementTest.php:class LanguageConfigurationElementTest extends WebTestBase {
modules/language/src/Tests/LanguageUILanguageNegotiationTest.php:class LanguageUILanguageNegotiationTest extends WebTestBase {
modules/language/src/Tests/LanguageSelectorTranslatableTest.php:class LanguageSelectorTranslatableTest extends WebTestBase {
modules/language/src/Tests/AdminPathEntityConverterLanguageTest.php:class AdminPathEntityConverterLanguageTest extends WebTestBase {
modules/language/src/Tests/LanguageCustomLanguageConfigurationTest.php:class LanguageCustomLanguageConfigurationTest extends WebTestBase {
modules/shortcut/src/Tests/ShortcutTestBase.php:abstract class ShortcutTestBase extends WebTestBase {
modules/block_content/src/Tests/BlockContentTestBase.php:abstract class BlockContentTestBase extends WebTestBase {
modules/path/src/Tests/PathTestBase.php:abstract class PathTestBase extends WebTestBase {
modules/simpletest/src/Tests/UserHelpersTest.php:class UserHelpersTest extends WebTestBase {
modules/simpletest/src/Tests/SimpleTestBrowserTest.php:class SimpleTestBrowserTest extends WebTestBase {
modules/simpletest/src/Tests/FolderTest.php:class FolderTest extends WebTestBase {
modules/simpletest/src/Tests/MailCaptureTest.php:class MailCaptureTest extends WebTestBase {
modules/simpletest/src/Tests/SimpleTestTest.php:class SimpleTestTest extends WebTestBase {
modules/simpletest/src/Tests/InstallationProfileModuleTestsTest.php:class InstallationProfileModuleTestsTest extends WebTestBase {
modules/simpletest/src/Tests/BrokenSetUpTest.php:class BrokenSetUpTest extends WebTestBase {
modules/simpletest/src/Tests/OtherInstallationProfileTestsTest.php:class OtherInstallationProfileTestsTest extends WebTestBase {
modules/simpletest/src/Tests/BrowserTest.php:class BrowserTest extends WebTestBase {
modules/simpletest/src/Tests/MissingCheckedRequirementsTest.php:class MissingCheckedRequirementsTest extends WebTestBase {
modules/simpletest/src/InstallerTestBase.php:abstract class InstallerTestBase extends WebTestBase {
modules/field/src/Tests/Email/EmailFieldTest.php:class EmailFieldTest extends WebTestBase {
modules/field/src/Tests/Number/NumberFieldTest.php:class NumberFieldTest extends WebTestBase {
modules/field/src/Tests/reEnableModuleFieldTest.php:class reEnableModuleFieldTest extends WebTestBase {
modules/field/src/Tests/FieldHelpTest.php:class FieldHelpTest extends WebTestBase {
modules/field/src/Tests/FieldTestBase.php:abstract class FieldTestBase extends WebTestBase {
modules/field/src/Tests/String/StringFieldTest.php:class StringFieldTest extends WebTestBase {
modules/field/src/Tests/Boolean/BooleanFieldTest.php:class BooleanFieldTest extends WebTestBase {
modules/quickedit/src/Tests/QuickEditLoadingTest.php:class QuickEditLoadingTest extends WebTestBase {
modules/quickedit/src/Tests/QuickEditAutocompleteTermTest.php:class QuickEditAutocompleteTermTest extends WebTestBase {
modules/comment/src/Tests/CommentTestBase.php:abstract class CommentTestBase extends WebTestBase {
modules/comment/src/Tests/CommentUninstallTest.php:class CommentUninstallTest extends WebTestBase {
modules/comment/src/Tests/CommentNonNodeTest.php:class CommentNonNodeTest extends WebTestBase {
modules/comment/src/Tests/CommentLanguageTest.php:class CommentLanguageTest extends WebTestBase {
modules/comment/src/Tests/CommentBookTest.php:class CommentBookTest extends WebTestBase {
modules/menu_link_content/src/Tests/LinksTest.php:class LinksTest extends WebTestBase {
modules/aggregator/src/Tests/AggregatorTestBase.php:abstract class AggregatorTestBase extends WebTestBase {
modules/telephone/src/Tests/TelephoneFieldTest.php:class TelephoneFieldTest extends WebTestBase {
modules/contextual/src/Tests/ContextualDynamicContextTest.php:class ContextualDynamicContextTest extends WebTestBase {
modules/datetime/src/Tests/DateTimeFieldTest.php:class DateTimeFieldTest extends WebTestBase {
modules/history/src/Tests/HistoryTest.php:class HistoryTest extends WebTestBase {
modules/toolbar/src/Tests/ToolbarAdminMenuTest.php:class ToolbarAdminMenuTest extends WebTestBase {
modules/toolbar/src/Tests/ToolbarHookToolbarTest.php:class ToolbarHookToolbarTest extends WebTestBase {
modules/toolbar/src/Tests/ToolbarMenuTranslationTest.php:class ToolbarMenuTranslationTest extends WebTestBase {
modules/system/src/Tests/Condition/ConditionFormTest.php:class ConditionFormTest extends WebTestBase {
modules/system/src/Tests/Pager/PagerTest.php:class PagerTest extends WebTestBase {
modules/system/src/Tests/FileTransfer/FileTransferTest.php:class FileTransferTest extends WebTestBase {
modules/system/src/Tests/Datetime/DrupalDateTimeTest.php:class DrupalDateTimeTest extends WebTestBase {
modules/system/src/Tests/Module/ClassLoaderTest.php:class ClassLoaderTest extends WebTestBase {
modules/system/src/Tests/Module/UninstallTest.php:class UninstallTest extends WebTestBase {
modules/system/src/Tests/Module/ModuleTestBase.php:abstract class ModuleTestBase extends WebTestBase {
modules/system/src/Tests/Module/InstallTest.php:class InstallTest extends WebTestBase {
modules/system/src/Tests/Path/UrlAlterFunctionalTest.php:class UrlAlterFunctionalTest extends WebTestBase {
modules/system/src/Tests/Session/SessionTest.php:class SessionTest extends WebTestBase {
modules/system/src/Tests/Session/SessionHttpsTest.php:class SessionHttpsTest extends WebTestBase {
modules/system/src/Tests/Image/ToolkitSetupFormTest.php:class ToolkitSetupFormTest extends WebTestBase {
modules/system/src/Tests/Image/ToolkitTestBase.php:abstract class ToolkitTestBase extends WebTestBase {
modules/system/src/Tests/Page/DefaultMetatagsTest.php:class DefaultMetatagsTest extends WebTestBase {
modules/system/src/Tests/Bootstrap/DrupalSetMessageTest.php:class DrupalSetMessageTest extends WebTestBase {
modules/system/src/Tests/Bootstrap/PageCacheTest.php:class PageCacheTest extends WebTestBase {
modules/system/src/Tests/Mail/HtmlToTextTest.php:class HtmlToTextTest extends WebTestBase {
modules/system/src/Tests/Mail/MailTest.php:class MailTest extends WebTestBase {
modules/system/src/Tests/Batch/PageTest.php:class PageTest extends WebTestBase {
modules/system/src/Tests/Batch/ProcessingTest.php:class ProcessingTest extends WebTestBase {
modules/system/src/Tests/Common/FormatDateTest.php:class FormatDateTest extends WebTestBase {
modules/system/src/Tests/Common/AddFeedTest.php:class AddFeedTest extends WebTestBase {
modules/system/src/Tests/Common/UrlTest.php:class UrlTest extends WebTestBase {
modules/system/src/Tests/Common/SimpleTestErrorCollectorTest.php:class SimpleTestErrorCollectorTest extends WebTestBase {
modules/system/src/Tests/Common/RenderWebTest.php:class RenderWebTest extends WebTestBase {
modules/system/src/Tests/Common/AlterTest.php:class AlterTest extends WebTestBase {
modules/system/src/Tests/Common/NoJavaScriptAnonymousTest.php:class NoJavaScriptAnonymousTest extends WebTestBase {
modules/system/src/Tests/Database/DatabaseWebTestBase.php:abstract class DatabaseWebTestBase extends WebTestBase {
modules/system/src/Tests/Cache/CacheTestBase.php:abstract class CacheTestBase extends WebTestBase {
modules/system/src/Tests/Cache/PageCacheTagsTestBase.php:abstract class PageCacheTagsTestBase extends WebTestBase {
modules/system/src/Tests/Cache/PageCacheTagsIntegrationTest.php:class PageCacheTagsIntegrationTest extends WebTestBase {
modules/system/src/Tests/Ajax/AjaxTestBase.php:abstract class AjaxTestBase extends WebTestBase {
modules/system/src/Tests/Update/InvalidUpdateHookTest.php:class InvalidUpdateHookTest extends WebTestBase {
modules/system/src/Tests/Update/DependencyHookInvocationTest.php:class DependencyHookInvocationTest extends WebTestBase {
modules/system/src/Tests/Update/DependencyOrderingTest.php:class DependencyOrderingTest extends WebTestBase {
modules/system/src/Tests/Update/UpdatesWith7xTest.php:class UpdatesWith7xTest extends WebTestBase {
modules/system/src/Tests/Update/UpdateScriptTest.php:class UpdateScriptTest extends WebTestBase {
modules/system/src/Tests/Update/DependencyMissingTest.php:class DependencyMissingTest extends WebTestBase {
modules/system/src/Tests/System/CronQueueTest.php:class CronQueueTest extends WebTestBase {
modules/system/src/Tests/System/SystemConfigFormTestBase.php:abstract class SystemConfigFormTestBase extends WebTestBase {
modules/system/src/Tests/System/FrontPageTest.php:class FrontPageTest extends WebTestBase {
modules/system/src/Tests/System/PageTitleTest.php:class PageTitleTest extends WebTestBase {
modules/system/src/Tests/System/DateFormatsMachineNameTest.php:class DateFormatsMachineNameTest extends WebTestBase {
modules/system/src/Tests/System/PageNotFoundTest.php:class PageNotFoundTest extends WebTestBase {
modules/system/src/Tests/System/DateFormatsLockedTest.php:class DateFormatsLockedTest extends WebTestBase {
modules/system/src/Tests/System/FloodTest.php:class FloodTest extends WebTestBase {
modules/system/src/Tests/System/DateTimeTest.php:class DateTimeTest extends WebTestBase {
modules/system/src/Tests/System/MainContentFallbackTest.php:class MainContentFallbackTest extends WebTestBase {
modules/system/src/Tests/System/AccessDeniedTest.php:class AccessDeniedTest extends WebTestBase {
modules/system/src/Tests/System/SiteMaintenanceTest.php:class SiteMaintenanceTest extends WebTestBase {
modules/system/src/Tests/System/ShutdownFunctionsTest.php:class ShutdownFunctionsTest extends WebTestBase {
modules/system/src/Tests/System/TokenScanTest.php:class TokenScanTest extends WebTestBase {
modules/system/src/Tests/System/AdminMetaTagTest.php:class AdminMetaTagTest extends WebTestBase {
modules/system/src/Tests/System/RetrieveFileTest.php:class RetrieveFileTest extends WebTestBase {
modules/system/src/Tests/System/HtaccessTest.php:class HtaccessTest extends WebTestBase {
modules/system/src/Tests/System/SystemAuthorizeTest.php:class SystemAuthorizeTest extends WebTestBase {
modules/system/src/Tests/System/AdminTest.php:class AdminTest extends WebTestBase {
modules/system/src/Tests/System/TrustedHostsTest.php:class TrustedHostsTest extends WebTestBase {
modules/system/src/Tests/System/ThemeTest.php:class ThemeTest extends WebTestBase {
modules/system/src/Tests/System/StatusTest.php:class StatusTest extends WebTestBase {
modules/system/src/Tests/System/ErrorHandlerTest.php:class ErrorHandlerTest extends WebTestBase {
modules/system/src/Tests/System/IndexPhpTest.php:class IndexPhpTest extends WebTestBase {
modules/system/src/Tests/System/DefaultMobileMetaTagsTest.php:class DefaultMobileMetaTagsTest extends WebTestBase {
modules/system/src/Tests/System/CronRunTest.php:class CronRunTest extends WebTestBase {
modules/system/src/Tests/ServiceProvider/ServiceProviderTest.php:class ServiceProviderTest extends WebTestBase {
modules/system/src/Tests/Entity/EntityFormTest.php:class EntityFormTest extends WebTestBase {
modules/system/src/Tests/Entity/EntityReferenceSelection/EntityReferenceSelectionAccessTest.php:class EntityReferenceSelectionAccessTest extends WebTestBase {
modules/system/src/Tests/Entity/EntityOperationsTest.php:class EntityOperationsTest extends WebTestBase {
modules/system/src/Tests/Entity/EntityRevisionsTest.php:class EntityRevisionsTest extends WebTestBase {
modules/system/src/Tests/Entity/ConfigEntityImportTest.php:class ConfigEntityImportTest extends WebTestBase {
modules/system/src/Tests/Entity/EntityViewControllerTest.php:class EntityViewControllerTest extends WebTestBase {
modules/system/src/Tests/Entity/EntityTranslationFormTest.php:class EntityTranslationFormTest extends WebTestBase {
modules/system/src/Tests/Entity/EntityListBuilderTest.php:class EntityListBuilderTest extends WebTestBase {
modules/system/src/Tests/Theme/FunctionsTest.php:class FunctionsTest extends WebTestBase {
modules/system/src/Tests/Theme/FastTest.php:class FastTest extends WebTestBase {
modules/system/src/Tests/Theme/ThemeEarlyInitializationTest.php:class ThemeEarlyInitializationTest extends WebTestBase {
modules/system/src/Tests/Theme/EntityFilteringThemeTest.php:class EntityFilteringThemeTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigFilterTest.php:class TwigFilterTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigExtensionTest.php:class TwigExtensionTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigNamespaceTest.php:class TwigNamespaceTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigDebugMarkupTest.php:class TwigDebugMarkupTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigRegistryLoaderTest.php:class TwigRegistryLoaderTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigRawTest.php:class TwigRawTest extends WebTestBase {
modules/system/src/Tests/Theme/EnginePhpTemplateTest.php:class EnginePhpTemplateTest extends WebTestBase {
modules/system/src/Tests/Theme/ThemeInfoTest.php:class ThemeInfoTest extends WebTestBase {
modules/system/src/Tests/Theme/ThemeSuggestionsAlterTest.php:class ThemeSuggestionsAlterTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigSettingsTest.php:class TwigSettingsTest extends WebTestBase {
modules/system/src/Tests/Theme/ThemeTest.php:class ThemeTest extends WebTestBase {
modules/system/src/Tests/Theme/HtmlAttributesTest.php:class HtmlAttributesTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigLoaderTest.php:class TwigLoaderTest extends WebTestBase {
modules/system/src/Tests/Theme/TwigTransTest.php:class TwigTransTest extends WebTestBase {
modules/system/src/Tests/Theme/EngineTwigTest.php:class EngineTwigTest extends WebTestBase {
modules/system/src/Tests/DrupalKernel/ContentNegotiationTest.php:class ContentNegotiationTest extends WebTestBase {
modules/system/src/Tests/Lock/LockFunctionalTest.php:class LockFunctionalTest extends WebTestBase {
modules/system/src/Tests/File/ConfigTest.php:class ConfigTest extends WebTestBase {
modules/system/src/Tests/Menu/MenuRouterTest.php:class MenuRouterTest extends WebTestBase {
modules/system/src/Tests/Menu/MenuTranslateTest.php:class MenuTranslateTest extends WebTestBase {
modules/system/src/Tests/Menu/LocalTasksTest.php:class LocalTasksTest extends WebTestBase {
modules/system/src/Tests/Menu/LocalActionTest.php:class LocalActionTest extends WebTestBase {
modules/system/src/Tests/Menu/MenuTestBase.php:abstract class MenuTestBase extends WebTestBase {
modules/system/src/Tests/Routing/RouterPermissionTest.php:class RouterPermissionTest extends WebTestBase {
modules/system/src/Tests/Routing/RouterTest.php:class RouterTest extends WebTestBase {
modules/system/src/Tests/Installer/SiteNameTest.php:class SiteNameTest extends WebTestBase {
modules/system/src/Tests/Form/SystemConfigFormTest.php:class SystemConfigFormTest extends WebTestBase {
modules/system/src/Tests/Form/StateValuesCleanAdvancedTest.php:class StateValuesCleanAdvancedTest extends WebTestBase {
modules/system/src/Tests/Form/LanguageSelectElementTest.php:class LanguageSelectElementTest extends WebTestBase {
modules/system/src/Tests/Form/StorageTest.php:class StorageTest extends WebTestBase {
modules/system/src/Tests/Form/ValidationTest.php:class ValidationTest extends WebTestBase {
modules/system/src/Tests/Form/EmailTest.php:class EmailTest extends WebTestBase {
modules/system/src/Tests/Form/ElementsTableSelectTest.php:class ElementsTableSelectTest extends WebTestBase {
modules/system/src/Tests/Form/FormTest.php:class FormTest extends WebTestBase {
modules/system/src/Tests/Form/ElementTest.php:class ElementTest extends WebTestBase {
modules/system/src/Tests/Form/ProgrammaticTest.php:class ProgrammaticTest extends WebTestBase {
modules/system/src/Tests/Form/UrlTest.php:class UrlTest extends WebTestBase {
modules/system/src/Tests/Form/ConfirmFormTest.php:class ConfirmFormTest extends WebTestBase {
modules/system/src/Tests/Form/ModulesListFormWebTest.php:class ModulesListFormWebTest extends WebTestBase {
modules/system/src/Tests/Form/FormStoragePageCacheTest.php:class FormStoragePageCacheTest extends WebTestBase {
modules/system/src/Tests/Form/ElementsLabelsTest.php:class ElementsLabelsTest extends WebTestBase {
modules/system/src/Tests/Form/ArbitraryRebuildTest.php:class ArbitraryRebuildTest extends WebTestBase {
modules/system/src/Tests/Form/RebuildTest.php:class RebuildTest extends WebTestBase {
modules/system/src/Tests/Form/AlterTest.php:class AlterTest extends WebTestBase {
modules/system/src/Tests/Form/RedirectTest.php:class RedirectTest extends WebTestBase {
modules/system/src/Tests/Form/ResponseTest.php:class ResponseTest extends WebTestBase {
modules/system/src/Tests/Form/CheckboxTest.php:class CheckboxTest extends WebTestBase {
modules/system/src/Tests/Form/ElementsVerticalTabsTest.php:class ElementsVerticalTabsTest extends WebTestBase {
modules/system/src/Tests/Form/StateValuesCleanTest.php:class StateValuesCleanTest extends WebTestBase {
modules/system/src/Tests/Form/TriggeringElementTest.php:class TriggeringElementTest extends WebTestBase {
modules/system/src/Tests/ParamConverter/UpcastingTest.php:class UpcastingTest extends WebTestBase {
modules/config_translation/src/Tests/ConfigTranslationOverviewTest.php:class ConfigTranslationOverviewTest extends WebTestBase {
modules/config_translation/src/Tests/ConfigTranslationFormTest.php:class ConfigTranslationFormTest extends WebTestBase {
modules/config_translation/src/Tests/ConfigTranslationUiThemeTest.php:class ConfigTranslationUiThemeTest extends WebTestBase {
modules/config_translation/src/Tests/ConfigTranslationListUiTest.php:class ConfigTranslationListUiTest extends WebTestBase {
modules/config_translation/src/Tests/ConfigTranslationUiTest.php:class ConfigTranslationUiTest extends WebTestBase {
modules/action/src/Tests/ConfigurationTest.php:class ConfigurationTest extends WebTestBase {
modules/action/src/Tests/ActionUninstallTest.php:class ActionUninstallTest extends WebTestBase {
modules/action/src/Tests/BulkFormTest.php:class BulkFormTest extends WebTestBase {
modules/rest/src/Tests/RESTTestBase.php:abstract class RESTTestBase extends WebTestBase {
modules/forum/src/Tests/ForumBlockTest.php:class ForumBlockTest extends WebTestBase {
modules/forum/src/Tests/ForumUninstallTest.php:class ForumUninstallTest extends WebTestBase {
modules/forum/src/Tests/ForumTest.php:class ForumTest extends WebTestBase {
modules/forum/src/Tests/ForumIndexTest.php:class ForumIndexTest extends WebTestBase {
modules/forum/src/Tests/ForumNodeAccessTest.php:class ForumNodeAccessTest extends WebTestBase {
modules/file/src/Tests/FileFieldTestBase.php:abstract class FileFieldTestBase extends WebTestBase {
modules/file/src/Tests/FileManagedTestBase.php:abstract class FileManagedTestBase extends WebTestBase {
modules/rdf/src/Tests/GetNamespacesTest.php:class GetNamespacesTest extends WebTestBase {
modules/rdf/src/Tests/UserAttributesTest.php:class UserAttributesTest extends WebTestBase {
modules/rdf/src/Tests/GetRdfNamespacesTest.php:class GetRdfNamespacesTest extends WebTestBase {
modules/rdf/src/Tests/StandardProfileTest.php:class StandardProfileTest extends WebTestBase {
modules/color/src/Tests/ColorTest.php:class ColorTest extends WebTestBase {
modules/color/src/Tests/ColorConfigSchemaTest.php:class ColorConfigSchemaTest extends WebTestBase {
modules/user/src/Tests/UserAccountLinksTests.php:class UserAccountLinksTests extends WebTestBase {
modules/user/src/Tests/UserLanguageCreationTest.php:class UserLanguageCreationTest extends WebTestBase {
modules/user/src/Tests/UserPermissionsTest.php:class UserPermissionsTest extends WebTestBase {
modules/user/src/Tests/UserSignatureTest.php:class UserSignatureTest extends WebTestBase {
modules/user/src/Tests/UserTokenReplaceTest.php:class UserTokenReplaceTest extends WebTestBase {
modules/user/src/Tests/UserRolesAssignmentTest.php:class UserRolesAssignmentTest extends WebTestBase {
modules/user/src/Tests/UserTimeZoneTest.php:class UserTimeZoneTest extends WebTestBase {
modules/user/src/Tests/UserLanguageTest.php:class UserLanguageTest extends WebTestBase {
modules/user/src/Tests/UserCreateFailMailTest.php:class UserCreateFailMailTest extends WebTestBase {
modules/user/src/Tests/UserAdminListingTest.php:class UserAdminListingTest extends WebTestBase {
modules/user/src/Tests/UserEditTest.php:class UserEditTest extends WebTestBase {
modules/user/src/Tests/UserCancelTest.php:class UserCancelTest extends WebTestBase {
modules/user/src/Tests/UserPictureTest.php:class UserPictureTest extends WebTestBase {
modules/user/src/Tests/UserRegistrationTest.php:class UserRegistrationTest extends WebTestBase {
modules/user/src/Tests/UserBlocksTest.php:class UserBlocksTest extends WebTestBase {
modules/user/src/Tests/UserCreateTest.php:class UserCreateTest extends WebTestBase {
modules/user/src/Tests/UserEditedOwnAccountTest.php:class UserEditedOwnAccountTest extends WebTestBase {
modules/user/src/Tests/UserPasswordResetTest.php:class UserPasswordResetTest extends WebTestBase {
modules/user/src/Tests/UserAutocompleteTest.php:class UserAutocompleteTest extends WebTestBase {
modules/user/src/Tests/UserSearchTest.php:class UserSearchTest extends WebTestBase {
modules/user/src/Tests/UserValidateCurrentPassCustomFormTest.php:class UserValidateCurrentPassCustomFormTest extends WebTestBase {
modules/user/src/Tests/UserAdminLanguageTest.php:class UserAdminLanguageTest extends WebTestBase {
modules/user/src/Tests/UserEntityCallbacksTest.php:class UserEntityCallbacksTest extends WebTestBase {
modules/user/src/Tests/UserAdminTest.php:class UserAdminTest extends WebTestBase {
modules/user/src/Tests/UserLoginTest.php:class UserLoginTest extends WebTestBase {
modules/user/src/Tests/UserDeleteTest.php:class UserDeleteTest extends WebTestBase {
modules/user/src/Tests/UserSaveTest.php:class UserSaveTest extends WebTestBase {
modules/user/src/Tests/UserRoleAdminTest.php:class UserRoleAdminTest extends WebTestBase {
modules/statistics/src/Tests/StatisticsLoggingTest.php:class StatisticsLoggingTest extends WebTestBase {
modules/statistics/src/Tests/StatisticsTestBase.php:abstract class StatisticsTestBase extends WebTestBase {
modules/statistics/src/Tests/StatisticsAdminTest.php:class StatisticsAdminTest extends WebTestBase {
modules/config/src/Tests/ConfigExportUITest.php:class ConfigExportUITest extends WebTestBase {
modules/config/src/Tests/ConfigLanguageOverrideWebTest.php:class ConfigLanguageOverrideWebTest extends WebTestBase {
modules/config/src/Tests/ConfigSingleImportExportTest.php:class ConfigSingleImportExportTest extends WebTestBase {
modules/config/src/Tests/ConfigEntityListTest.php:class ConfigEntityListTest extends WebTestBase {
modules/config/src/Tests/ConfigExportImportUITest.php:class ConfigExportImportUITest extends WebTestBase {
modules/config/src/Tests/SchemaConfigListenerWebTest.php:class SchemaConfigListenerWebTest extends WebTestBase {
modules/config/src/Tests/ConfigEntityTest.php:class ConfigEntityTest extends WebTestBase {
modules/config/src/Tests/ConfigEntityStatusUITest.php:class ConfigEntityStatusUITest extends WebTestBase {
modules/config/src/Tests/ConfigImportUITest.php:class ConfigImportUITest extends WebTestBase {
modules/config/src/Tests/ConfigEntityFormOverrideTest.php:class ConfigEntityFormOverrideTest extends WebTestBase {
modules/config/src/Tests/ConfigImportUploadTest.php:class ConfigImportUploadTest extends WebTestBase {
modules/config/src/Tests/ConfigOtherModuleTest.php:class ConfigOtherModuleTest extends WebTestBase {
modules/config/src/Tests/ConfigInstallWebTest.php:class ConfigInstallWebTest extends WebTestBase {
modules/config/src/Tests/ConfigFormOverrideTest.php:class ConfigFormOverrideTest extends WebTestBase {
modules/dblog/src/Tests/DbLogTest.php:class DbLogTest extends WebTestBase {
modules/node/src/Tests/NodeAccessPagerTest.php:class NodeAccessPagerTest extends WebTestBase {
modules/node/src/Tests/NodeFieldMultilingualTest.php:class NodeFieldMultilingualTest extends WebTestBase {
modules/node/src/Tests/NodeTestBase.php:abstract class NodeTestBase extends WebTestBase {
modules/node/src/Tests/NodeHelpTest.php:class NodeHelpTest extends WebTestBase {
modules/node/src/Tests/NodeTypeRenameConfigImportTest.php:class NodeTypeRenameConfigImportTest extends WebTestBase {
modules/block/src/Tests/BlockTemplateSuggestionsUnitTest.php:class BlockTemplateSuggestionsUnitTest extends WebTestBase {
modules/block/src/Tests/BlockHookOperationTest.php:class BlockHookOperationTest extends WebTestBase {
modules/block/src/Tests/BlockTitleXSSTest.php:class BlockTitleXSSTest extends WebTestBase {
modules/block/src/Tests/BlockInvalidRegionTest.php:class BlockInvalidRegionTest extends WebTestBase {
modules/block/src/Tests/NewDefaultThemeBlocksTest.php:class NewDefaultThemeBlocksTest extends WebTestBase {
modules/block/src/Tests/BlockLanguageCacheTest.php:class BlockLanguageCacheTest extends WebTestBase {
modules/block/src/Tests/BlockRenderOrderTest.php:class BlockRenderOrderTest extends WebTestBase {
modules/block/src/Tests/BlockUiTest.php:class BlockUiTest extends WebTestBase {
modules/block/src/Tests/BlockCacheTest.php:class BlockCacheTest extends WebTestBase {
modules/block/src/Tests/BlockHtmlTest.php:class BlockHtmlTest extends WebTestBase {
modules/block/src/Tests/BlockAdminThemeTest.php:class BlockAdminThemeTest extends WebTestBase {
modules/block/src/Tests/BlockTestBase.php:abstract class BlockTestBase extends WebTestBase {
modules/block/src/Tests/BlockHiddenRegionTest.php:class BlockHiddenRegionTest extends WebTestBase {
modules/block/src/Tests/NonDefaultBlockAdminTest.php:class NonDefaultBlockAdminTest extends WebTestBase {
modules/block/src/Tests/BlockLanguageTest.php:class BlockLanguageTest extends WebTestBase {
modules/link/src/Tests/LinkFieldTest.php:class LinkFieldTest extends WebTestBase {
modules/link/src/Tests/LinkFieldUITest.php:class LinkFieldUITest extends WebTestBase {
modules/syslog/src/Tests/SyslogTest.php:class SyslogTest extends WebTestBase {
modules/basic_auth/src/Tests/Authentication/BasicAuthTest.php:class BasicAuthTest extends WebTestBase {
modules/views_ui/src/Tests/NewViewConfigSchemaTest.php:class NewViewConfigSchemaTest extends WebTestBase {
modules/views_ui/src/Tests/ReportTest.php:class ReportTest extends WebTestBase {
modules/content_translation/src/Tests/ContentTranslationSettingsTest.php:class ContentTranslationSettingsTest extends WebTestBase {
modules/content_translation/src/Tests/ContentTranslationEntityBundleUITest.php:class ContentTranslationEntityBundleUITest extends WebTestBase {
modules/content_translation/src/Tests/ContentTranslationContextualLinksTest.php:class ContentTranslationContextualLinksTest extends WebTestBase {
modules/content_translation/src/Tests/ContentTranslationStandardFieldsTest.php:class ContentTranslationStandardFieldsTest extends WebTestBase {
modules/content_translation/src/Tests/ContentTranslationTestBase.php:abstract class ContentTranslationTestBase extends WebTestBase {
modules/entity_reference/src/Tests/EntityReferenceAutoCreateTest.php:class EntityReferenceAutoCreateTest extends WebTestBase {
modules/entity_reference/src/Tests/EntityReferenceAdminTest.php:class EntityReferenceAdminTest extends WebTestBase {
modules/entity_reference/src/Tests/EntityReferenceFieldTranslatedReferenceViewTest.php:class EntityReferenceFieldTranslatedReferenceViewTest extends WebTestBase {
modules/entity_reference/src/Tests/EntityReferenceIntegrationTest.php:class EntityReferenceIntegrationTest extends WebTestBase {
modules/entity_reference/src/Tests/Views/SelectionTest.php:class SelectionTest extends WebTestBase {
modules/entity_reference/src/Tests/EntityReferenceFieldDefaultValueTest.php:class EntityReferenceFieldDefaultValueTest extends WebTestBase {
modules/views/src/Tests/ViewTestBase.php:abstract class ViewTestBase extends WebTestBase {
modules/responsive_image/src/Tests/ResponsiveImageAdminUITest.php:class ResponsiveImageAdminUITest extends WebTestBase {
modules/responsive_image/src/Tests/ResponsiveImageFieldUiTest.php:class ResponsiveImageFieldUiTest extends WebTestBase {
modules/update/src/Tests/UpdateTestBase.php:abstract class UpdateTestBase extends WebTestBase {
modules/image/src/Tests/FileMoveTest.php:class FileMoveTest extends WebTestBase {
modules/image/src/Tests/ImageThemeFunctionTest.php:class ImageThemeFunctionTest extends WebTestBase {
modules/image/src/Tests/ImageStylesPathAndUrlTest.php:class ImageStylesPathAndUrlTest extends WebTestBase {
modules/image/src/Tests/ImageFieldTestBase.php:abstract class ImageFieldTestBase extends WebTestBase {
modules/image/src/Tests/ImageDimensionsTest.php:class ImageDimensionsTest extends WebTestBase {
modules/taxonomy/src/Tests/TaxonomyTestBase.php:abstract class TaxonomyTestBase extends WebTestBase {
modules/field_ui/src/Tests/ManageFieldsTest.php:class ManageFieldsTest extends WebTestBase {
modules/field_ui/src/Tests/EntityDisplayModeTest.php:class EntityDisplayModeTest extends WebTestBase {
modules/field_ui/src/Tests/FieldUIRouteTest.php:class FieldUIRouteTest extends WebTestBase {
modules/field_ui/src/Tests/ManageDisplayTest.php:class ManageDisplayTest extends WebTestBase {
modules/tracker/src/Tests/TrackerNodeAccessTest.php:class TrackerNodeAccessTest extends WebTestBase {
modules/tracker/src/Tests/TrackerTest.php:class TrackerTest extends WebTestBase {
modules/editor/src/Tests/QuickEditIntegrationLoadingTest.php:class QuickEditIntegrationLoadingTest extends WebTestBase {
modules/editor/src/Tests/EditorAdminTest.php:class EditorAdminTest extends WebTestBase {
modules/editor/src/Tests/EditorLoadingTest.php:class EditorLoadingTest extends WebTestBase {
modules/editor/src/Tests/EditorSecurityTest.php:class EditorSecurityTest extends WebTestBase {
modules/book/src/Tests/BookTest.php:class BookTest extends WebTestBase {

Looking for wrong named classes/files I found these:

modules/language/src/Tests/LanguageBrowserDetectionUnitTest.php:class LanguageBrowserDetectionUnitTest extends WebTestBase {
modules/block/src/Tests/BlockTemplateSuggestionsUnitTest.php:class BlockTemplateSuggestionsUnitTest extends WebTestBase {
modules/user/src/Tests/UserAccountLinksTests.php:class UserAccountLinksTests extends WebTestBase {

Also I made a search among all the classes here that are base classes, then among all of these I got one result from the resulting subclasses:

modules/taxonomy/src/Tests/TaxonomyTestBase.php:abstract class TaxonomyTestBase extends WebTestBase {

modules/taxonomy/src/Tests/TermUnitTest.php:class TermUnitTest extends TaxonomyTestBase {
betoscopio’s picture

betoscopio
Primary language Spanish
commented
Title: Rename some functional SimpleTest WebTestBase test classes acording to code standards » Simpletest web tests misnamed as "Unit"

Renaming these classes:

modules/language/src/Tests/LanguageBrowserDetectionUnitTest.php:class LanguageBrowserDetectionUnitTest extends WebTestBase {
modules/block/src/Tests/BlockTemplateSuggestionsUnitTest.php:class BlockTemplateSuggestionsUnitTest extends WebTestBase {
modules/taxonomy/src/Tests/TermUnitTest.php:class TermUnitTest extends TaxonomyTestBase {

The other missnamed file has its own issue #2426323: Rename UserAccountLinksTests to UserAccountLinksTest.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
StatusFileSize
new simpletest-webtest-mislabeled-1847280-11.patch1.43 KB

I'm uploading a new patch renaming the classes LanguageBrowserDetectionUnitTest, BlockTemplateSuggestionsUnitTest.

The class TermUnitTest can't be renamed, because TermTest already exists. This function should be renamed or take another action to this file fulfill the tests code standards.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new simpletest-webtest-mislabeled-1847280-12.patch1.78 KB

The diff was made wrong, reuploading the patch.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Issue tags: +LatinAmerica2015
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

This is about tests and that is allowed for beta-changes.

Good work @betoscopio.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/block/src/Tests/BlockTemplateSuggestionsTest.php
@@ -14,7 +14,7 @@
-class BlockTemplateSuggestionsUnitTest extends WebTestBase {
+class BlockTemplateSuggestionsTest extends WebTestBase {

Can we change this to a KernelTestBase test whilst we are changing this.

Also can we get a followup to change TermUnitTest to a KernelTestBase test by moving createTerm and createVocabulary to a trait. This followup should also rename the test.

yesct’s picture

yesct commented
Status: Needs work » Needs review
StatusFileSize
new simpletest-webtest-mislabeled-1847280-16.patch1.91 KB
new interdiff.1847280.12.16.txt676 bytes

doing that.

yesct’s picture

yesct commented

@alexpott made the issue #2431477: make TermUnitTest a KernelTestBase by moving createTerm and createVocabulary to a trait

Status: Needs review » Needs work

The last submitted patch, 16: simpletest-webtest-mislabeled-1847280-16.patch, failed testing.

yesct’s picture

yesct commented
Assigned: betoscopio » Unassigned
Status: Needs work » Needs review
StatusFileSize
new simpletest-webtest-mislabeled-1847280-19.patch1.78 KB
new interdiff-1847280.12.19.txt1 KB

since that is more than just renaming, lets fix the name here, and change it in #2432647: Convert BlockTemplateSuggestionsTest into a KernelTestBase


going back to <a href="#comment-9622297">#12</a>

reading I noticed.

+++ b/core/modules/block/src/Tests/BlockTemplateSuggestionsTest.php
@@ -2,7 +2,7 @@
- * Definition of Drupal\block\Tests\BlockTemplateSuggestionsUnitTest.
+ * Contains of Drupal\block\Tests\BlockTemplateSuggestionsTest.

should be "Contains \Drupal" not "Contains of Drupal..."

https://www.drupal.org/node/1354#file

---
did that.

(git diff --color-words is helpful in cases like this)

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looks good. Sub-issue spun off for Alex's question.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed b84eabf on 8.0.x 
    Issue #1847280 by YesCT, betoscopio: Simpletest web tests misnamed as "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.