ToolbarHookToolbarTest does this:

    $this->drupalGet('/node');

The preceding slash is invalid, but since we're not testing the actual content of the page, it's better to decouple it from node (or any specific module or path) and instead use the page testing module intended for this purpose.

Attached fixes that, and has a few textual cleanups as a bonus.

CommentFileSizeAuthor
toolbar-test.patch1.67 KBxjm

Comments

xjm’s picture

Title: ToolbarHookToolbarTest has invalid preceding slash (and other cleanups) » ToolbarHookToolbarTest has invalid preceding slash in path (and other cleanups)
xjm’s picture

Issue tags: +Testing system, +VDC
yesct’s picture

Status: Needs review » Reviewed & tested by the community

I checked this, it meets coding standards, and the docs standards. It also does what it says it does in the summary: uses a test page (without the /)

passes the bot too.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.