Posted by sylus on November 22, 2012 at 2:19pm
9 followers
| Project: | Panopoly |
| Version: | 7.x-1.x-dev |
| Component: | Widgets |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | a11y |
Issue Summary
The latest release of File Entity has the RBTC commit for Alt and Title Support: http://drupal.org/node/1553094
Are we able to add this :)
I have attached a patch
Comments
#1
Patch
#2
Attaching proper one
#3
I finally got alt and title working with media but wanted to make sure these would be the right steps (can attach a patch later)
So with patches:
1) http://drupal.org/node/1307054#comment-6764108
2) #1553094: Alt and Title support for Images or latest release from File_Entity (7.x-2.0-unstable7)
and in hook_wysiwyg_editor_settings_alter
// Allow extra elements for Media module
// See - http://drupal.org/node/1835826
$settings['extended_valid_elements'] .= ',img[src|view_mode|format|fid|alt|title]';
I now finally have working alt and title tags! :)
Is there anything I am missing? :)
#4
Changing title to be more reflective
#5
I've tested the patch and the changes to panopoly_wysiwyg module, and I can confirm that this works properly. If we can also have it so we can adjust the alt/title tag after embedding the image (possibly by utilizing TinyMCE's image plugin upon selecting the image), I think we should have a solid implementation.
Thanks, sylus!
#6
Glad to see this is moving ahead here! Just a quick note to say that the proper patch (for media) is in #89:
http://drupal.org/node/1307054#comment-6791808
@Pcho, this one addresses the ability to alter alt & title in wysiwyg instances.
@Sylus, we discovered some issues after #80 (mentioned above), it would be great to get an eye or two on that and RTBC it!
Cheers,
JP
#7
This seems to be 2 issues to me:
1) Alt & Title support in media is the the most obvious outcome but the real news is that Multi Step forms are enabled which allows for fields on the file_entity to actually be used on forms. This is major. As a side benefit, alt and title now are fields on the image file type and can be added during upload.
2) Proper alt/title support within wysiwyg. This depends on issue 1. (Ok, technically not the 2 step form thing but come on, its pretty freaking awesome so we should include that)
For issue 1, no patches are necessary, just module updates
http://drupal.org/files/1847912-panopoly-widgets-update-media-file-entit...
For issue 2, the above works great at first glance!
http://drupal.org/files/1307054-d7-2-alt-text-89.patch
http://drupal.org/files/1847912-panopoly-wysiwyg-alt-title-support-7.patch
While it is great that we can have 2, i'm most excited about actually being able to make use of file types now.
#8
Rolling the media change into the patch for panopoly_widgets so i can build with drush make
#9
This sounds great. I updated the media and file entity modules to the latest version and can confirm alt/title works with images (assuming patch from #1857998). This is all committed and good to go.
#10
Automatically closed -- issue fixed for 2 weeks with no activity.