Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
translation_entity.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Nov 2012 at 20:09 UTC
Updated:
29 Jul 2014 at 21:33 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Bojhan commentedSure, though I am not sure if one would really want all possible tabs as contextual links. I don't necessarily think that is a good practice.
Comment #2
aspilicious commentedHere isa picture of the current links
Comment #3
aspilicious commentedI know some people wanting this. So I guess it has a use case.
Comment #4
swentel commentedThis should at least do it when using the old translation module for nodes and probably enable it for any entity when using entity translation.
Comment #5
yesct commentedI think aspilicious is suggesting adding translation, not all possible tabs.
Also, for people like me who didn't know... can see that gear and drop down shown in #2 on the site default front page after content is created.
Comment #6
swentel commentedWoops forgot a constant, better patch.
Comment #7
yesct commentedSee if #1832778-8: Include translation operation in overviews for translatable entities and #1832778-11: Include translation operation in overviews for translatable entities relate to this.
They mention #1783964: Allow entity types to provide menu items and #1828410: Provide a bulk_form element for actions
Also... VBO.
Comment #8
swentel commentedThey relate in a way yes, but they have added it to a different place.
Comment #9
yesct commentedManual testing of the patch from #6 just on nodes with basic page not translation enabled, article translation enabled.
Only thing I noticed right off was the order of the tabs is different than the order contextual links. (needs work for this, unless someone else thinks otherwise)
Patch works.
The translation contextual link that it ads does work too and goes to the translation overview as expected.
This next bit is a won't fix and has to do with the label on the translations tab: And it's more noticeable as contextual links that view and edit look like actions and "translations" looks like an overview of the translations tab (which it is) instead of an action like "translate". The translate action is really not from the tabs, but from the "add" link available from the translations overview table. or the "edit" link from those same rows (which edit the node or edit the translation).
Comment #10
yesct commentedOh, I didn't notice that the tabs are view and edit and the contextual links are edit and delete. hmm.
Then the order makes sense. (edit, translations, delete)
needs review for general approach/code review.
Comment #11
gábor hojtsyI think the code change looks good. It modifies both modules. The contextual menu item should only show up if the menu tab would (by definition and existing tests for contextual links). So I think this is good to go.
Comment #12
webchickThis makes a lot of sense to me, as this is one of the primary actions users are going to want to perform on their sites if the translation module's enabled. I don't view this as a feature, merely updating the existing UI to be more consistent, so re-classifying as a task.
Committed and pushed to 8.x. Thanks!