Random warnings in tests in field_ui.admin.inc [#1848200]

- TestFieldWidgetMultiple declares no field_type entry in its annotation.
This entry is added in a alter hook, that is used in a test that checks alter hooks are fired.
- However, due to #1780396: Namespaces of disabled modules are registered during test runs, there are cases where the class is found, but not the alter hook
- Therefore, we end up with a widget definition that has no 'field_types' entry.

Bumping to critical, as it seems to raise issues in a couple tested patches - though, not in HEAD, not sure why.
Patch coming up.

Comment	File	Size	Author
#5	field_ui_warnings-1848200-5.patch	1.33 KB	yched
#1	field_ui_warnings-1848200-1.patch	1.32 KB	yched

Comments

Comment #1

yched commented 22 November 2012 at 21:18

Status:

Reviewed & tested by the community

» Active

Status	File	Size
new	field_ui_warnings-1848200-1.patch	1.32 KB

Attached patch :
- Adds an empty 'field_types' entry in TestFieldWidgetMultiple's annotations
- Makes sure an empty 'field_types' entry is always added to discovered definitions (PluginManager::$defaults)

Comment #2

xjm

she/her

English

commented 22 November 2012 at 21:12

Status:

Active

» Needs review

Comment #3

berdir

German

Switzerland

commented 22 November 2012 at 21:16

Status:

Needs review

» Reviewed & tested by the community

Don't know why HEAD doesn't fail right now either, but this makes sense, is simple and is blocking #1806334: Replace the node listing at /node with a view, #1292470: Convert user pictures to Image Field (both major tasks) and possibly more.

RTBC if it comes back green from the bot.

Comment #4

yched commented 23 November 2012 at 10:46

Status:

Active

» Needs work

Testbot didn't report back, but there were fails - http://qa.drupal.org/pifr/test/390698
Looking I'll look into this asap

Comment #5

yched commented 23 November 2012 at 12:47

Status	File	Size
new	field_ui_warnings-1848200-5.patch	1.33 KB

So, turns out the annotations reader cannot parse an "empty array" entry and crashes when it meets one.
Opened #1848570: Upgrade to Doctrine\Common 2.4 for that.

So, patch just has the PluginManager make sure the entry is present, which it should.
Added it on formatters too - and removed 'default_value' over there, this has nothing to do here and is a wrong copy/paste from WidgetPluginManager.