Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Open Graph
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Nov 2012 at 13:21 UTC
Updated:
23 Jan 2014 at 05:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaI'm fairly new to dealing with translations, would you mind either providing a patch, explaining what needs to be done or providing a link to documentation on how to do this? Thanks.
Comment #2
damienmckennaString context info: http://drupal.org/node/1369936
Comment #3
damienmckennaWould this work? I've added a the context "location".
Comment #4
damienmckennaI've changed it to 'business', added the same context to the other businesses and then also added a new context to some of the other strings.
Comment #5
damienmckennaForgot to hit save before creating the patch.
Comment #6
dave reidIs there some kind of unified way to know what value to use for context? For example: band is music and not noun? Maybe we should standardize all of these and use a context of 'OpenGraph type' instead since that's truly the context being used?
Comment #7
dave reidComment #8
gábor hojtsyDave: there is no clear consensus in #1035716: [policy, no patch] Decide and document guidelines for using string context but that is the issue for the discussion you are referring to. I agree things like Bar and Band are very ambiguous and would need context provided.
Comment #9
damienmckenna@Gábor: Thanks for chiming in. Any suggestion on what should be used in this situation as the context for "bar"?
Comment #10
damienmckennaTag.
Comment #11
sutharsan commentedFirst, and foremost: A context is only required when a translation conflict exists. Don't add contexts for potential conflicts. This issue was opened for a conflict on 'bar', unless there have been (non-documented) discussion with stonor, please remove all contexts except for 'bar'.
My first guideline for contexts is that a context describes the linguistic meaning in its context. My suggestions for 'Bar' context this case: 'an establishment' or (popular) 'where beer is served'.
Comment #12
damienmckenna@Sutharsan: thanks for your help. I've updated the patch to use "an establishment", as suggested, and removed the other contexts.
Comment #13
damienmckennaCommitted. Thanks for your help, everyone!