Optimize the performance of PluginBase::setOptionDefaults

#5: drupal-1849280-5.patch queued for re-testing.

#23: drupal-1849280-23.patch queued for re-testing.

The changes look great! Two small nitpicks

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/PluginBase.phpundefined
@@ -99,17 +99,27 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+   * Fill up the options of the plugin with defaults.

Fills

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/PluginBase.phpundefined
@@ -99,17 +99,27 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+   *   An array which stores the actual option values of the plugin.
+   *
+   * @param array $options

No blank line needed

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/PluginBase.phpundefined
@@ -99,17 +99,27 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+   *     - default: The default value of one option
+   *     - contains: (optional) An array which describes the available options
+   *       under the key.

These are indented 2 spaces too much, and the (optional) goes before the key name I think

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/Boolean.phpundefined
@@ -38,7 +38,7 @@ protected function defineOptions() {
-    $options['not'] = array('definition bool' => 'reverse');
+    $options['not'] = array('default' => FALSE, 'bool' => TRUE);

Hahaha, what was that? :)

The removed $level param hasn't been used since Views 6.x-2.x, so in theory this clean-up could get backported.

Nice work @dawehner!

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/PluginBase.phpundefined
@@ -99,17 +99,26 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
       if (isset($definition['contains']) && is_array($definition['contains'])) {

If we are trimming the fat out of this method, should/could we also assume that if 'contains' is set, it will be an array.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/PluginBase.phpundefined
@@ -99,17 +99,26 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+   *   - default: The default value of one option
+   *   - (optional) contains: An array which describes the available options
+   *       under the key.

Small thing: Should we add the translatable key to the docs too?

I have also just opened #1922966: Remove 'bool' and 'translatable' key from option definitions as a related follow up.

Oops, must have x-posted

Yay performance!

Committed and pushed to 8.x. Thanks!