Bugged assumption in ModuleTestBase::assertModuleConfig()

Ah, that's much cleaner.

I confirmed locally that this also fixes #1806334: Replace the node listing at /node with a view; however, I'm seeing a couple other failures locally.

Ah, the failures with #2 #1 are caused by the fact that Breakpoint only provides breakpoint.yml, which I guess is not matched by listAll('breakpoint.').

The problem is:

  $extension = '.' . self::getFileExtension();
  $files = glob($this->directory . '/' . $prefix . '*' . $extension);

If the prefix is breakpoint., then this pattern will only match breakpoint.*.yml. Weird that this hasn't caused other problems.

Ah yes, #1701014: Validate config object names is the problem exactly. Edit: well, a complement to it, maybe we need to re-scope that issue a little. So we consider breakpoint.yml an invalid config filename, and the config filename must always have two(-plus) parts?

Aside, finding the string breakpoint to replace it with breakpoint.settings within the module directory is entertaining. Here's just the file rename as a start.

Uh. The fact that #7 passes makes me wonder about breakpoint's test coverage. We just renamed breakpoint.multipliers to breakpoint.settings.multipliers, so it seems like something should fail? I guess there's no coverage for whether defaults are installed.

[lorentz:breakpoint | Sun 18:17:44] $ grep -r "multipliers" *
breakpoint.module:      $output .= '<dt>' . t('Assigning resolution multipliers to breakpoints') . '</dt>';
breakpoint.module:      $output .= '<dd>' . t('Multipliers are a measure of the viewport\'s device resolution, defined to be the ratio between the physical pixel size of the active device and the <a href="http://en.wikipedia.org/wiki/Device_independent_pixel">device-independent pixel</a> size. The Breakpoint module defines multipliers of 1, 1.5, and 2; when defining breakpoints, modules and themes can define which multipliers apply to each breakpoint.') . '</dd>';
config/breakpoint.yml:multipliers: [1x, 1.5x, 2x]
lib/Drupal/breakpoint/Plugin/Core/Entity/Breakpoint.php:   * The breakpoint multipliers.
lib/Drupal/breakpoint/Plugin/Core/Entity/Breakpoint.php:   * @var multipliers
lib/Drupal/breakpoint/Plugin/Core/Entity/Breakpoint.php:  public $multipliers = array();
lib/Drupal/breakpoint/Plugin/Core/Entity/Breakpoint.php:    // Remove unused multipliers.
lib/Drupal/breakpoint/Plugin/Core/Entity/Breakpoint.php:    $this->multipliers = array_filter($this->multipliers);
lib/Drupal/breakpoint/Plugin/Core/Entity/Breakpoint.php:    if (!array_key_exists('1x', $this->multipliers)) {
lib/Drupal/breakpoint/Plugin/Core/Entity/Breakpoint.php:      $this->multipliers = array('1x' => '1x') + $this->multipliers;
lib/Drupal/breakpoint/Tests/BreakpointCRUDTest.php:    $breakpoint->multipliers['2x'] = '2x';
lib/Drupal/breakpoint/Tests/BreakpointTestBase.php:      'multipliers',

Yeah, as far as I can tell Breakpoint doesn't even use what's in that yaml file at all, so we're not actually even breaking anything that isn't already broken. Maybe it was intended for use once a UI was added?

Per webchick's request I tested existing breakpoints in standard with this patch applied and confirmed none of the behavior changes. The toolbar still flips its orientation from horizontal to vertical, and the primary navigation still switches from tabs to touch buttons. The text labels next to the icons also still get hidden.

Filed #1851018: Improve breakpoint configuration implementation..

I'm not sure #17 is the correct fix for this; it's unblocking one issue to block another.

Yeah, this looks correct to me assuming it passes. The comments in #25 are excellent.