Posted by Bojhan on November 25, 2012 at 8:37pm
8 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | other |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | Usability |
Issue Summary
Part of #1238484: Ability to mark the form buttons to be of a specific type (so that they can be styled differently). I am here marking all the buttons in structure blue.
To keep this patch effort, somewhat manageable I am doing it per section.
Comments
#1
This is basically, for all usecases were we have two buttons.
Because we are not yet sure, we want it on all primary buttons - I didn't do that here.
#2
#3
Now the patch to mark all primary buttons blue in Structure.
*This has a serious side-effect, it also marks all forms that implement system_config_form its "Save configuration" buttons blue.
#4
+++ b/core/modules/block/block.admin.incundefined@@ -173,6 +173,7 @@ function block_admin_display_form($form, &$form_state, $blocks, $theme, $block_r
+ '#button_type' => 'primary',
Tabs instead of spaces everywhere you put #button_type
+++ b/core/modules/menu/menu.admin.incundefined@@ -407,8 +408,8 @@ function menu_edit_item($form, &$form_state, $type, $item, $menu) {
+ ¶
A space
#5
Cool, that can be fixed.
Setting this back to review to get more feedback on changing the UI guideline, from using blue buttons "everywhere there are two buttons" to "everywhere we can find a primary button".
#6
Yes, I think that makes sense. It will make that blue button something you can rely on, you can click it and the form will be submitted/your stuff will be saved. Lets do this :)
#7
This is not part of toolbar module...
#8
The screenshots in #3 look a bit weird to me. OTOH, yoroy's "blue button something you can rely on, you can click it and the form will be submitted/your stuff will be saved" makes sense to me. Let's try it and we can always revisit later if we decide it's overwhelming.
#9
Agreed, can someone else fix the spaces - I dont know how to get those tabs to show up in my editor
#10
#11
Patch needs a bit of cleanup
#12
Nice crosspost :)
#13
None of the primary submits in Field UI are blue. Intentional or oversight?
#14
Intentional, I think we need to figure out what to do with those two buttons its one of the few places in core we do it and it doesn't have a clear 80% primary button.
#15
I tested the patch and it does what it says it does. I opened #1853260: Which ones of the Field UI submit buttons should be blue? to discuss the special snowflakes that are in Field UI.
#16
This looks good to me, fine with tackling Field UI in a follow-up, so I've committed/pushed to 8.x.
#17
Automatically closed -- issue fixed for 2 weeks with no activity.