I see an option to set an order total minimum value, but is there no way to set a maximum?

A common coupon would be 50% on orders less than $5

That would mean a loss of less than 2.50 on usage of the coupon. It's not possible to set such a limit, so a 50% coupon could be a loss of hundreds of dollars if the order is big enough.

Am I missing this setting?

CommentFileSizeAuthor
#5 uc_coupon-maximum_value_for_coupon-1850294-6.patch6.1 KBtmsimont
#4 uc_coupon_suggestion.zip31.02 KBdjg_tram

Comments

wodenx’s picture

wodenx commented

There's currently no way to set a maximum value for a % based coupon. This could be implemeted one (or both) of 2 ways
- allow specifying a maximum discount which would come into play if any type of coupon resulted in a combination of discounts that was greater
- allow a "max order total" condition, which would invalidate a coupon if the order total were greater
Will gladly entertain patches for this functionality.

djg_tram’s picture

djg_tram commented

I need that functionality as well and I'm adding it right now. But, considering that I have a non-dev version on a production site that I need to modify, I won't be able to provide a full patch, just a set of source files where I mark every modification. Would somebody still accept it as a contribution? :-)

tmsimont’s picture

tmsimont commented

if you post you're code i'd probably do a patch for it

djg_tram’s picture

djg_tram commented
StatusFileSize
new uc_coupon_suggestion.zip31.02 KB

Now I realized it also contained some other suggestions that make it possible to use externally generated bulk codes. I can no longer remember whether I sent that in already or only wanted to. :-) Anyway, I throw it in now, together with the extra module.

Look for //DJG comments.

Thanks.

tmsimont’s picture

tmsimont commented
Version: 7.x-2.1-alpha7 » 7.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new uc_coupon-maximum_value_for_coupon-1850294-6.patch6.1 KB

thanks djg -- I tried to create a patch against 7.x-3.x and it's unfortunately pretty far behind that branch.

Thanks to your comments though, I was able to find which bits you added and got a patch made for 7.x-3.x

I'm doing it for 3.x because typically new features get applied to the latest dev branch.

I also added an update function so your new field gets added.

For now, I left out the uc_bulk stuff. I think you should open a new feature request issue for that and re-submit your code. For the maintainer's sake, it would be best to patch 1 feature at a time.

Please note -- this is just a port of djm's code to a patch (with an added update function) that I have not personally tested... I probably won't get a chance to test it for a few days.